Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 216773005: Porting to x64 Android. Remove redefinitions of log2 and log2f. (Closed)

Created:
6 years, 8 months ago by Anton
Modified:
6 years, 8 months ago
CC:
bajones, Zhenyao Mo
Visibility:
Public.

Description

Porting to x64 Android. Remove redefinitions of log2 and log2f. BUG= R=kbr@chromium.org Committed: 261106

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -42 lines) Patch
M src/gallium/auxiliary/util/u_math.h View 7 chunks +17 lines, -42 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Anton
Built locally with both ARM32 and x64. This definitions don't appear to be needed anymore ...
6 years, 8 months ago (2014-04-01 18:25:45 UTC) #1
scottmg
I don't think we do the .diff dance for mesa, but please update README.chromium in ...
6 years, 8 months ago (2014-04-01 18:28:44 UTC) #2
Ken Russell (switch to Gerrit)
LGTM As Scott points out, please update src/third_party/mesa/README.chromium when you roll Mesa's entry in src/DEPS. ...
6 years, 8 months ago (2014-04-01 22:55:20 UTC) #3
Ken Russell (switch to Gerrit)
On 2014/04/01 22:55:20, Ken Russell wrote: > LGTM > > As Scott points out, please ...
6 years, 8 months ago (2014-04-01 22:56:15 UTC) #4
rmcilroy
On 2014/04/01 22:56:15, Ken Russell wrote: > On 2014/04/01 22:55:20, Ken Russell wrote: > > ...
6 years, 8 months ago (2014-04-02 10:58:41 UTC) #5
rmcilroy
Committed patchset #1 manually as r261106 (presubmit successful).
6 years, 8 months ago (2014-04-02 10:59:38 UTC) #6
Nico
6 years, 8 months ago (2014-04-22 16:52:50 UTC) #7
Message was sent while issue was closed.
Did you file an upstream bug on mesa for this? (They've been pretty responsive
on our other bugs, e.g. https://bugs.freedesktop.org/show_bug.cgi?id=75336
https://bugs.freedesktop.org/show_bug.cgi?id=70743 etc). This will make life
easier the next time we update our mesa version.

Powered by Google App Engine
This is Rietveld 408576698