Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 216773003: Use the absolute magnitude instead of the bar level as the level of the input signal (Closed)

Created:
6 years, 9 months ago by no longer working on chromium
Modified:
6 years, 9 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Use the absolute magnitude instead of the bar level as the level of the input signal. NOTRY=true BUG=357566 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260212

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -20 lines) Patch
M content/renderer/media/media_stream_audio_level_calculator.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/media_stream_audio_level_calculator.cc View 2 chunks +1 line, -18 lines 2 comments Download

Messages

Total messages: 10 (0 generated)
no longer working on chromium
Tommi, PTAL. Thanks, SX https://codereview.chromium.org/216773003/diff/1/content/renderer/media/media_stream_audio_level_calculator.cc File content/renderer/media/media_stream_audio_level_calculator.cc (left): https://codereview.chromium.org/216773003/diff/1/content/renderer/media/media_stream_audio_level_calculator.cc#oldcode48 content/renderer/media/media_stream_audio_level_calculator.cc:48: static const int kPermutation[33] = ...
6 years, 9 months ago (2014-03-28 10:30:34 UTC) #1
no longer working on chromium
Tommi, PTAL. Thanks, SX https://codereview.chromium.org/216773003/diff/1/content/renderer/media/media_stream_audio_level_calculator.cc File content/renderer/media/media_stream_audio_level_calculator.cc (left): https://codereview.chromium.org/216773003/diff/1/content/renderer/media/media_stream_audio_level_calculator.cc#oldcode48 content/renderer/media/media_stream_audio_level_calculator.cc:48: static const int kPermutation[33] = ...
6 years, 9 months ago (2014-03-28 10:30:34 UTC) #2
tommi (sloooow) - chröme
lgtm. Please update the description as discussed offline before committing. https://codereview.chromium.org/216773003/diff/1/content/renderer/media/media_stream_audio_level_calculator.cc File content/renderer/media/media_stream_audio_level_calculator.cc (left): https://codereview.chromium.org/216773003/diff/1/content/renderer/media/media_stream_audio_level_calculator.cc#oldcode48 ...
6 years, 9 months ago (2014-03-28 11:57:02 UTC) #3
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 9 months ago (2014-03-28 12:06:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/216773003/1
6 years, 9 months ago (2014-03-28 12:13:30 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 17:53:48 UTC) #6
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) base_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=137483
6 years, 9 months ago (2014-03-28 17:53:49 UTC) #7
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 9 months ago (2014-03-28 18:30:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/216773003/1
6 years, 9 months ago (2014-03-28 18:32:26 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 18:36:45 UTC) #10
Message was sent while issue was closed. 
Change committed as 260212

Powered by Google App Engine
This is Rietveld 408576698