cc: Delete SurfaceDrawStatus

cc: Delete SurfaceDrawStatus

This is plumbed around but doesn't seem to be used in practice except for a
couple of EXPECTs in a unit test. This CL deletes it.

BUG=none
TBR=reveman@chromium.org for trivial exo change.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Committed: https://crrev.com/0be2d430252a16683aaa441401c388c97e7e292b
Cr-Commit-Position: refs/heads/master@{#406753}

[Fady Samuel, 2016-07-20 13:43:01]

Description was changed from

==========
cc: Delete SurfaceDrawStatus

This is plumbed around but doesn't seem to be used in practice except for a
couple of EXPECTs in a unit test. This CL deletes it.

BUG=none
==========

to

==========
cc: Delete SurfaceDrawStatus

This is plumbed around but doesn't seem to be used in practice except for a
couple of EXPECTs in a unit test. This CL deletes it.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Fady Samuel, 2016-07-20 13:43:01]

Description was changed from

==========
cc: Delete SurfaceDrawStatus

This is plumbed around but doesn't seem to be used in practice except for a
couple of EXPECTs in a unit test. This CL deletes it.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
cc: Delete SurfaceDrawStatus

This is plumbed around but doesn't seem to be used in practice except for a
couple of EXPECTs in a unit test. This CL deletes it.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[Fady Samuel, 2016-07-20 13:44:46]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 13:45:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2016-07-20 13:45:45]

fsamuel@chromium.org changed reviewers:
+ jbauman@chromium.org, piman@chromium.org, sky@chromium.org

[Fady Samuel, 2016-07-20 13:45:45]

+jbauman@ for cc
+piman@ for content
+sky@ for services/ui

[commit-bot: I haz the power, 2016-07-20 14:56:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 14:56:31]

Dry run: This issue passed the CQ dry run.

[sky, 2016-07-20 15:56:35]

https://codereview.chromium.org/2167713002/diff/1/services/ui/gpu/display_com...
File services/ui/gpu/display_compositor/compositor_frame_sink_impl.cc (right):

https://codereview.chromium.org/2167713002/diff/1/services/ui/gpu/display_com...
services/ui/gpu/display_compositor/compositor_frame_sink_impl.cc:16: void
CallCallback(
Is this function still needed? Can the callback be supplied directly now?

https://codereview.chromium.org/2167713002/diff/1/services/ui/public/interfac...
File services/ui/public/interfaces/gpu/display_compositor.mojom (right):

https://codereview.chromium.org/2167713002/diff/1/services/ui/public/interfac...
services/ui/public/interfaces/gpu/display_compositor.mojom:35: // After the
submitted frame is either drawn for the first time by the display
Update description.

https://codereview.chromium.org/2167713002/diff/1/services/ui/ws/server_windo...
File services/ui/ws/server_window_surface.cc (right):

https://codereview.chromium.org/2167713002/diff/1/services/ui/ws/server_windo...
services/ui/ws/server_window_surface.cc:20: void CallCallback(const
base::Closure& callback) {
Same comment here as to if callback can be supplied directly and this function
removed.

[jbauman, 2016-07-20 19:35:07]

lgtm

[Fady Samuel, 2016-07-20 20:31:33]

PTAL Scott!

https://codereview.chromium.org/2167713002/diff/1/services/ui/gpu/display_com...
File services/ui/gpu/display_compositor/compositor_frame_sink_impl.cc (right):

https://codereview.chromium.org/2167713002/diff/1/services/ui/gpu/display_com...
services/ui/gpu/display_compositor/compositor_frame_sink_impl.cc:16: void
CallCallback(
On 2016/07/20 15:56:35, sky wrote:
> Is this function still needed? Can the callback be supplied directly now?

Done.

https://codereview.chromium.org/2167713002/diff/1/services/ui/public/interfac...
File services/ui/public/interfaces/gpu/display_compositor.mojom (right):

https://codereview.chromium.org/2167713002/diff/1/services/ui/public/interfac...
services/ui/public/interfaces/gpu/display_compositor.mojom:35: // After the
submitted frame is either drawn for the first time by the display
On 2016/07/20 15:56:35, sky wrote:
> Update description.

Done.

https://codereview.chromium.org/2167713002/diff/1/services/ui/ws/server_windo...
File services/ui/ws/server_window_surface.cc (right):

https://codereview.chromium.org/2167713002/diff/1/services/ui/ws/server_windo...
services/ui/ws/server_window_surface.cc:20: void CallCallback(const
base::Closure& callback) {
On 2016/07/20 15:56:35, sky wrote:
> Same comment here as to if callback can be supplied directly and this function
> removed.

Done.

[Fady Samuel, 2016-07-20 20:31:40]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 20:32:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 20:56:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 20:56:51]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2016-07-20 21:45:04]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 21:45:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2016-07-20 21:47:18]

lgtm

[sky, 2016-07-20 22:06:17]

LGTM

[commit-bot: I haz the power, 2016-07-20 22:26:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 22:26:16]

Dry run: This issue passed the CQ dry run.

[Fady Samuel, 2016-07-21 01:19:01]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-07-21 01:19:02]

The patchset sent to the CQ was uploaded after l-g-t-m from jbauman@chromium.org
Link to the patchset: https://codereview.chromium.org/2167713002/#ps20001
(title: "Addressed Scott's comments")

[commit-bot: I haz the power, 2016-07-21 01:19:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 01:28:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 01:28:19]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2016-07-21 02:28:04]

fsamuel@chromium.org changed reviewers:
+ dcheng@chromium.org, reveman@chromium.org

[Fady Samuel, 2016-07-21 02:28:05]

+dcheng@ for display_compositor.mojom CompositorFrameDrawStatus deletion
+reveman@ for trivial exo change (TBR'ing).

[Fady Samuel, 2016-07-21 02:28:35]

Description was changed from

==========
cc: Delete SurfaceDrawStatus

This is plumbed around but doesn't seem to be used in practice except for a
couple of EXPECTs in a unit test. This CL deletes it.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
cc: Delete SurfaceDrawStatus

This is plumbed around but doesn't seem to be used in practice except for a
couple of EXPECTs in a unit test. This CL deletes it.

BUG=none
TBR=reveman@chromium.org for trivial exo change.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[dcheng, 2016-07-21 02:29:49]

rs lgtm for mojom changes (yay for code deletion)

[Fady Samuel, 2016-07-21 03:09:24]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2016-07-21 03:09:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 03:17:01]

Description was changed from

==========
cc: Delete SurfaceDrawStatus

This is plumbed around but doesn't seem to be used in practice except for a
couple of EXPECTs in a unit test. This CL deletes it.

BUG=none
TBR=reveman@chromium.org for trivial exo change.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
cc: Delete SurfaceDrawStatus

This is plumbed around but doesn't seem to be used in practice except for a
couple of EXPECTs in a unit test. This CL deletes it.

BUG=none
TBR=reveman@chromium.org for trivial exo change.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-07-21 03:17:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-21 03:20:11]

Description was changed from

==========
cc: Delete SurfaceDrawStatus

This is plumbed around but doesn't seem to be used in practice except for a
couple of EXPECTs in a unit test. This CL deletes it.

BUG=none
TBR=reveman@chromium.org for trivial exo change.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
cc: Delete SurfaceDrawStatus

This is plumbed around but doesn't seem to be used in practice except for a
couple of EXPECTs in a unit test. This CL deletes it.

BUG=none
TBR=reveman@chromium.org for trivial exo change.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Committed: https://crrev.com/0be2d430252a16683aaa441401c388c97e7e292b
Cr-Commit-Position: refs/heads/master@{#406753}
==========

[commit-bot: I haz the power, 2016-07-21 03:20:12]

Patchset 2 (id:??) landed as
https://crrev.com/0be2d430252a16683aaa441401c388c97e7e292b
Cr-Commit-Position: refs/heads/master@{#406753}