Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 2167703002: DEPS update: Breakpad 51db53eec729, LSS 3f6478ac95ed, NaCl 412a6e2bb153 (Closed)

Created:
4 years, 5 months ago by Mark Mentovai
Modified:
4 years, 4 months ago
CC:
chromium-reviews, Lei Zhang, vapier, Ting-Yuan (Leo) Huang, llozano
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DEPS update: Breakpad 51db53eec729, LSS 3f6478ac95ed, NaCl 412a6e2bb153 Yes, these three updates are truly interdependent. See https://crbug.com/629874. Breakpad was previously on a branch that had cherry-picked 027633792600. Breakpad 2fcb8afbc807 requires linux-syscall-support 3f6478ac95ed. The repository for linux-syscall-support has changed locations. Native Client also depends on linux-syscall-support and must be updated to 412a6e2bb153 for compatibility with this version of linux-syscall-support. Update Breakpad to 51db53eec7293a35cb6fc10bd2e333f22dd9d201 220c852dc209 Dump INFO CODE_ID containing Build ID in Linux dump_syms 2fcb8afbc807 linux-syscall-support: pull in latest version 1f7cb2e4c523 Server-side workaround to handle overlapping modules 8c612166fa87 Add a new argument to specify the minidump type to write on Windows 2131271ecabd [Android] Guard some NDK workarounds by major version 027633792600 Recover memory mappings before writing dump on ChromeOS 0de9e29cb674 Don't define |r_debug| and |link_map| on Android releases 21 and later e55a878d5b74 Add process type to MicroDumpExtraInfo 423e661072aa Add new exception code for OOM generated from Chromium 4dc6be51f90c Revert "Don't define |r_debug| and |link_map| on Android releases 21 and later" 51db53eec729 Remove DISALLOW_COPY_AND_ASSIGN from MinidumpStreamInfo Update linux-syscall-support to 3f6478ac95edf86cd3da300c2c0d34a438f5dbeb 2ce6a9744160 Add codereview.settings for new repo location cd0177fdded9 Fix VIEW_VC URL in codereview.settings 929203010984 Finally fix VIEW_VC url with proper review 08056836f2b4 migrate site/wiki docs over 348bdf8d32b3 README: clearly document goals/APIs/supported systems 3f6478ac95ed Add s390/s390x support to linux_syscall_support.h Update Native Client to 412a6e2bb153f39f22b9b3e47bc1ed0abb82df3f 412a6e2bb153 Update linux-syscall-support to 3f6478ac95ed Update generate_breakpad_symbols.py for Breakpad 220c852dc209. BUG=629874 TEST=tools/perf/run_tests core.stacktrace_unittest.TabStackTraceTest. Committed: https://crrev.com/051962e7c10d70da15f45a4c53fba88047f1dd71 Cr-Commit-Position: refs/heads/master@{#407569}

Patch Set 1 #

Patch Set 2 : 51db53eec729 #

Patch Set 3 : linux-syscall-support 3f6478ac95ed #

Patch Set 4 : Switch linux-syscall-support to new repository location #

Patch Set 5 : Fix linux-syscall-support git URL #

Patch Set 6 : Native Client 412a6e2bb153 #

Patch Set 7 : Update generate_breakpad_symbols.py for Breakpad 220c852dc209 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M DEPS View 1 2 3 4 5 4 chunks +5 lines, -5 lines 0 comments Download
M components/crash/content/tools/generate_breakpad_symbols.py View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 54 (46 generated)
Mark Mentovai
4 years, 5 months ago (2016-07-22 03:33:59 UTC) #33
Mark Seaborn
LGTM
4 years, 5 months ago (2016-07-22 18:29:08 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167703002/90001
4 years, 5 months ago (2016-07-22 18:32:42 UTC) #38
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/267726)
4 years, 5 months ago (2016-07-22 20:26:59 UTC) #40
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167703002/110001
4 years, 4 months ago (2016-07-25 18:39:34 UTC) #48
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167703002/110001
4 years, 4 months ago (2016-07-25 20:38:11 UTC) #51
commit-bot: I haz the power
Committed patchset #7 (id:110001)
4 years, 4 months ago (2016-07-25 20:45:21 UTC) #52
commit-bot: I haz the power
4 years, 4 months ago (2016-07-25 20:47:45 UTC) #54
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/051962e7c10d70da15f45a4c53fba88047f1dd71
Cr-Commit-Position: refs/heads/master@{#407569}

Powered by Google App Engine
This is Rietveld 408576698