components/crash/content/tools/generate_breakpad_symbols.py - Issue 2167703002: DEPS update: Breakpad 51db53eec729, LSS 3f6478ac95ed, NaCl 412a6e2bb153

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/crash/content/tools/generate_breakpad_symbols.py

Issue 2167703002: DEPS update: Breakpad 51db53eec729, LSS 3f6478ac95ed, NaCl 412a6e2bb153 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update generate_breakpad_symbols.py for Breakpad 220c852dc209 Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/crash/content/tools/generate_breakpad_symbols.py

diff --git a/components/crash/content/tools/generate_breakpad_symbols.py b/components/crash/content/tools/generate_breakpad_symbols.py

index b4c3b48a7002ed0e3ff0edadc15e9c6683659e9b..d076e8faae4fd0927fb0dbced9f67a8e944897d8 100755

--- a/components/crash/content/tools/generate_breakpad_symbols.py

+++ b/components/crash/content/tools/generate_breakpad_symbols.py

@@ -175,7 +175,7 @@ def GenerateSymbols(options, binaries):

break

binary_info = GetBinaryInfoFromHeaderInfo(

- GetCommandOutput([dump_syms, '-i', binary]))

+ GetCommandOutput([dump_syms, '-i', binary]).splitlines()[0])

if not binary_info:

should_dump_syms = False

reason = "Could not obtain binary information."

« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »