Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2167643005: Revert of mus: Rename .*PointerWatcher.* to .*PointerDownWatcher.*. (Closed)

Created:
4 years, 5 months ago by riajiang
Modified:
4 years, 5 months ago
Reviewers:
James Cook, sadrul, sky
CC:
chromium-reviews, kalyank, sadrul, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mus: Rename .*PointerWatcher.* to .*PointerDownWatcher.*. (patchset #5 id:80001 of https://codereview.chromium.org/2158273003/ ) Reason for revert: As discussed (https://codereview.chromium.org/2163453002/), changing PointerWatcher to watch for all events instead. Original issue's description: > mus: Rename .*PointerWatcher.* to .*PointerDownWatcher.* to avoid confusion with PointerEventWatcher (https://codereview.chromium.org/2163453002/). > > Committed: https://crrev.com/b2db88d57e677ab3ff4b3fc7f58896603816053c > Cr-Commit-Position: refs/heads/master@{#406584} Committed: https://crrev.com/957bb6a3d309e9994497b41817fda5b113683696 Cr-Commit-Position: refs/heads/master@{#407176}

Patch Set 1 #

Patch Set 2 : resolve conflicts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -402 lines) Patch
M ash/ash.gyp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ash/aura/wm_shell_aura.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ash/aura/wm_shell_aura.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
D ash/common/pointer_down_watcher_delegate.h View 1 chunk +0 lines, -28 lines 0 comments Download
A ash/common/pointer_watcher_delegate.h View 1 chunk +27 lines, -0 lines 0 comments Download
M ash/common/shelf/overflow_bubble.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ash/common/shelf/overflow_bubble.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ash/common/shell_delegate.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ash/common/system/tray/tray_event_filter.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ash/common/system/tray/tray_event_filter.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ash/common/wm_shell.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ash/mus/bridge/wm_shell_mus.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ash/mus/bridge/wm_shell_mus.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M ash/mus/shell_delegate_mus.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/mus/shell_delegate_mus.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
D ash/pointer_down_watcher_delegate_aura.h View 1 chunk +0 lines, -52 lines 0 comments Download
D ash/pointer_down_watcher_delegate_aura.cc View 1 chunk +0 lines, -65 lines 0 comments Download
A + ash/pointer_watcher_delegate_aura.h View 1 3 chunks +11 lines, -12 lines 0 comments Download
A + ash/pointer_watcher_delegate_aura.cc View 1 3 chunks +16 lines, -16 lines 0 comments Download
M ash/shelf/shelf_tooltip_manager.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ash/shelf/shelf_tooltip_manager.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ash/shell.h View 1 4 chunks +5 lines, -5 lines 0 comments Download
M ash/shell.cc View 1 4 chunks +8 lines, -8 lines 0 comments Download
M ash/shell/shell_delegate_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M ash/sysui/BUILD.gn View 1 1 chunk +2 lines, -2 lines 0 comments Download
D ash/sysui/pointer_down_watcher_delegate_mus.h View 1 chunk +0 lines, -29 lines 0 comments Download
D ash/sysui/pointer_down_watcher_delegate_mus.cc View 1 chunk +0 lines, -25 lines 0 comments Download
A ash/sysui/pointer_watcher_delegate_mus.h View 1 chunk +29 lines, -0 lines 0 comments Download
A ash/sysui/pointer_watcher_delegate_mus.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M ash/sysui/shell_delegate_mus.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/sysui/shell_delegate_mus.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M ash/test/test_shell_delegate.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/test/test_shell_delegate.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M ui/views/mus/window_manager_connection.h View 1 4 chunks +5 lines, -5 lines 0 comments Download
M ui/views/mus/window_manager_connection.cc View 1 5 chunks +14 lines, -17 lines 0 comments Download
M ui/views/mus/window_manager_connection_unittest.cc View 1 5 chunks +19 lines, -19 lines 0 comments Download
D ui/views/pointer_down_watcher.h View 1 chunk +0 lines, -48 lines 0 comments Download
A + ui/views/pointer_watcher.h View 1 3 chunks +7 lines, -7 lines 0 comments Download
M ui/views/views.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/views_exports.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (10 generated)
riajiang
Created Revert of mus: Rename .*PointerWatcher.* to .*PointerDownWatcher.*.
4 years, 5 months ago (2016-07-21 19:36:23 UTC) #1
riajiang
4 years, 5 months ago (2016-07-21 19:38:23 UTC) #4
James Cook
lgtm
4 years, 5 months ago (2016-07-21 21:07:44 UTC) #7
sky
Rubber stamp LGTM In the future please TBR mechanical reverts.
4 years, 5 months ago (2016-07-21 22:58:03 UTC) #8
sadrul
lgtm lgtm + cq
4 years, 5 months ago (2016-07-22 01:07:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167643005/1
4 years, 5 months ago (2016-07-22 01:08:19 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/39624) ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 5 months ago (2016-07-22 01:11:09 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167643005/300001
4 years, 5 months ago (2016-07-22 16:04:42 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:300001)
4 years, 5 months ago (2016-07-22 17:00:38 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 17:02:33 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/957bb6a3d309e9994497b41817fda5b113683696
Cr-Commit-Position: refs/heads/master@{#407176}

Powered by Google App Engine
This is Rietveld 408576698