Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: ui/views/mus/window_manager_connection_unittest.cc

Issue 2167643005: Revert of mus: Rename .*PointerWatcher.* to .*PointerDownWatcher.*. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: resolve conflicts Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/mus/window_manager_connection.cc ('k') | ui/views/pointer_down_watcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/mus/window_manager_connection_unittest.cc
diff --git a/ui/views/mus/window_manager_connection_unittest.cc b/ui/views/mus/window_manager_connection_unittest.cc
index eaf51f481e38cf97ec327f52c52c603d49c0a836..e84d9eae989e423a3e863176a68396372911944f 100644
--- a/ui/views/mus/window_manager_connection_unittest.cc
+++ b/ui/views/mus/window_manager_connection_unittest.cc
@@ -9,17 +9,17 @@
#include "base/message_loop/message_loop.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/events/event.h"
-#include "ui/views/pointer_down_watcher.h"
+#include "ui/views/pointer_watcher.h"
#include "ui/views/test/scoped_views_test_helper.h"
#include "ui/views/touch_event_watcher.h"
namespace views {
namespace {
-class TestPointerDownWatcher : public PointerDownWatcher {
+class TestPointerWatcher : public PointerWatcher {
public:
- TestPointerDownWatcher() {}
- ~TestPointerDownWatcher() override {}
+ TestPointerWatcher() {}
+ ~TestPointerWatcher() override {}
bool mouse_pressed() const { return mouse_pressed_; }
bool touch_pressed() const { return touch_pressed_; }
@@ -29,7 +29,7 @@ class TestPointerDownWatcher : public PointerDownWatcher {
touch_pressed_ = false;
}
- // PointerDownWatcher:
+ // PointerWatcher:
void OnMousePressed(const ui::MouseEvent& event,
const gfx::Point& location_in_screen,
Widget* target) override {
@@ -45,7 +45,7 @@ class TestPointerDownWatcher : public PointerDownWatcher {
bool mouse_pressed_ = false;
bool touch_pressed_ = false;
- DISALLOW_COPY_AND_ASSIGN(TestPointerDownWatcher);
+ DISALLOW_COPY_AND_ASSIGN(TestPointerWatcher);
};
} // namespace
@@ -88,7 +88,7 @@ class WindowManagerConnectionTest : public testing::Test {
DISALLOW_COPY_AND_ASSIGN(WindowManagerConnectionTest);
};
-TEST_F(WindowManagerConnectionTest, PointerDownWatcher) {
+TEST_F(WindowManagerConnectionTest, PointerWatcher) {
base::MessageLoop message_loop(base::MessageLoop::TYPE_UI);
ScopedViewsTestHelper helper;
WindowManagerConnection* connection = WindowManagerConnection::Get();
@@ -99,43 +99,43 @@ TEST_F(WindowManagerConnectionTest, PointerDownWatcher) {
base::TimeTicks());
ui::KeyEvent key_pressed(ui::ET_KEY_PRESSED, ui::VKEY_A, 0);
- // PointerDownWatchers receive mouse events.
- TestPointerDownWatcher watcher1;
- connection->AddPointerDownWatcher(&watcher1);
+ // PointerWatchers receive mouse events.
+ TestPointerWatcher watcher1;
+ connection->AddPointerWatcher(&watcher1);
OnEventObserved(mouse_pressed);
EXPECT_TRUE(watcher1.mouse_pressed());
watcher1.Reset();
- // PointerDownWatchers receive touch events.
+ // PointerWatchers receive touch events.
OnEventObserved(touch_pressed);
EXPECT_TRUE(watcher1.touch_pressed());
watcher1.Reset();
- // PointerDownWatchers do not trigger for key events.
+ // PointerWatchers do not trigger for key events.
OnEventObserved(key_pressed);
EXPECT_FALSE(watcher1.mouse_pressed());
EXPECT_FALSE(watcher1.touch_pressed());
watcher1.Reset();
- // Two PointerDownWatchers can both receive a single observed event.
- TestPointerDownWatcher watcher2;
- connection->AddPointerDownWatcher(&watcher2);
+ // Two PointerWatchers can both receive a single observed event.
+ TestPointerWatcher watcher2;
+ connection->AddPointerWatcher(&watcher2);
OnEventObserved(mouse_pressed);
EXPECT_TRUE(watcher1.mouse_pressed());
EXPECT_TRUE(watcher2.mouse_pressed());
watcher1.Reset();
watcher2.Reset();
- // Removing the first PointerDownWatcher stops sending events to it.
- connection->RemovePointerDownWatcher(&watcher1);
+ // Removing the first PointerWatcher stops sending events to it.
+ connection->RemovePointerWatcher(&watcher1);
OnEventObserved(mouse_pressed);
EXPECT_FALSE(watcher1.mouse_pressed());
EXPECT_TRUE(watcher2.mouse_pressed());
watcher1.Reset();
watcher2.Reset();
- // Removing the last PointerDownWatcher stops sending events to it.
- connection->RemovePointerDownWatcher(&watcher2);
+ // Removing the last PointerWatcher stops sending events to it.
+ connection->RemovePointerWatcher(&watcher2);
OnEventObserved(mouse_pressed);
EXPECT_FALSE(watcher1.mouse_pressed());
EXPECT_FALSE(watcher1.touch_pressed());
« no previous file with comments | « ui/views/mus/window_manager_connection.cc ('k') | ui/views/pointer_down_watcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698