Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2167473003: Revert of Renaming Gnubby and RemoteSecurityKey files/classes/members (Closed)

Created:
4 years, 5 months ago by hayato
Modified:
4 years, 5 months ago
Reviewers:
Sergey Ulanov, joedow
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Renaming Gnubby and RemoteSecurityKey files/classes/members (patchset #3 id:40001 of https://codereview.chromium.org/2162083003/ ) Reason for revert: Build break: https://build.chromium.org/p/chromium.mac/builders/Mac%20GYP%20%28dbg%29/builds/1194 Original issue's description: > Renaming Gnubby and RemoteSecurityKey files/classes/members > > This change is a simple refactoring to rename the 'Gnubby' and > 'RemoteSecurityKey' file/class names/comments/etc to be consistent. > I've chosen to use 'SecurityKey' as it is shorter that RemoteSecurityKey > (which was causing too many 80 char limit issues). No functional > changes are expected as a result of this change. > > Note: Not every instance of Gnubby or RemoteSecurityKey has been > changed. The registry key used for toggling this functionality still > uses 'gnubby'. I don't want to change that here. Also, the process > used on the host machine is still called remote_security_key so classes > associated with that process were not renamed (neither were the IPC > messages used by it). > > BUG=593736 > TBR=jochen@chromium.org > > Committed: https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516 > Cr-Commit-Position: refs/heads/master@{#406435} TBR=sergeyu@chromium.org,joedow@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=593736 Committed: https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a Cr-Commit-Position: refs/heads/master@{#406440}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6770 lines, -6751 lines) Patch
M PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/BUILD.gn View 2 chunks +18 lines, -18 lines 0 comments Download
M remoting/host/host_mock_objects.h View 3 chunks +9 lines, -9 lines 0 comments Download
M remoting/host/host_mock_objects.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 6 chunks +17 lines, -19 lines 0 comments Download
A remoting/host/security_key/fake_ipc_gnubby_auth_handler.h View 1 chunk +72 lines, -0 lines 0 comments Download
A remoting/host/security_key/fake_ipc_gnubby_auth_handler.cc View 1 chunk +63 lines, -0 lines 0 comments Download
D remoting/host/security_key/fake_ipc_security_key_auth_handler.h View 1 chunk +0 lines, -72 lines 0 comments Download
D remoting/host/security_key/fake_ipc_security_key_auth_handler.cc View 1 chunk +0 lines, -66 lines 0 comments Download
A remoting/host/security_key/fake_remote_security_key_ipc_client.h View 1 chunk +117 lines, -0 lines 0 comments Download
A remoting/host/security_key/fake_remote_security_key_ipc_client.cc View 1 chunk +130 lines, -0 lines 0 comments Download
A remoting/host/security_key/fake_remote_security_key_ipc_server.h View 1 chunk +136 lines, -0 lines 0 comments Download
A remoting/host/security_key/fake_remote_security_key_ipc_server.cc View 1 chunk +127 lines, -0 lines 0 comments Download
A remoting/host/security_key/fake_remote_security_key_message_reader.h View 1 chunk +48 lines, -0 lines 0 comments Download
A remoting/host/security_key/fake_remote_security_key_message_reader.cc View 1 chunk +30 lines, -0 lines 0 comments Download
A remoting/host/security_key/fake_remote_security_key_message_writer.h View 1 chunk +65 lines, -0 lines 0 comments Download
A remoting/host/security_key/fake_remote_security_key_message_writer.cc View 1 chunk +53 lines, -0 lines 0 comments Download
D remoting/host/security_key/fake_security_key_ipc_client.h View 1 chunk +0 lines, -117 lines 0 comments Download
D remoting/host/security_key/fake_security_key_ipc_client.cc View 1 chunk +0 lines, -127 lines 0 comments Download
D remoting/host/security_key/fake_security_key_ipc_server.h View 1 chunk +0 lines, -134 lines 0 comments Download
D remoting/host/security_key/fake_security_key_ipc_server.cc View 1 chunk +0 lines, -120 lines 0 comments Download
D remoting/host/security_key/fake_security_key_message_reader.h View 1 chunk +0 lines, -47 lines 0 comments Download
D remoting/host/security_key/fake_security_key_message_reader.cc View 1 chunk +0 lines, -30 lines 0 comments Download
D remoting/host/security_key/fake_security_key_message_writer.h View 1 chunk +0 lines, -60 lines 0 comments Download
D remoting/host/security_key/fake_security_key_message_writer.cc View 1 chunk +0 lines, -53 lines 0 comments Download
A remoting/host/security_key/gnubby_auth_handler.h View 1 chunk +71 lines, -0 lines 0 comments Download
A remoting/host/security_key/gnubby_auth_handler_android.cc View 1 chunk +15 lines, -0 lines 0 comments Download
A remoting/host/security_key/gnubby_auth_handler_linux.cc View 1 chunk +283 lines, -0 lines 0 comments Download
A remoting/host/security_key/gnubby_auth_handler_linux_unittest.cc View 1 chunk +248 lines, -0 lines 0 comments Download
A remoting/host/security_key/gnubby_auth_handler_mac.cc View 1 chunk +17 lines, -0 lines 0 comments Download
A remoting/host/security_key/gnubby_auth_handler_win.cc View 1 chunk +305 lines, -0 lines 0 comments Download
A remoting/host/security_key/gnubby_auth_handler_win_unittest.cc View 1 chunk +535 lines, -0 lines 0 comments Download
A remoting/host/security_key/gnubby_extension.h View 1 chunk +37 lines, -0 lines 0 comments Download
A remoting/host/security_key/gnubby_extension.cc View 1 chunk +35 lines, -0 lines 0 comments Download
A remoting/host/security_key/gnubby_extension_session.h View 1 chunk +67 lines, -0 lines 0 comments Download
A remoting/host/security_key/gnubby_extension_session.cc View 1 chunk +211 lines, -0 lines 0 comments Download
A remoting/host/security_key/gnubby_extension_session_unittest.cc View 1 chunk +435 lines, -0 lines 0 comments Download
A remoting/host/security_key/gnubby_socket.h View 1 chunk +113 lines, -0 lines 0 comments Download
A remoting/host/security_key/gnubby_socket.cc View 1 chunk +188 lines, -0 lines 0 comments Download
A remoting/host/security_key/remote_security_key_ipc_client.h View 1 chunk +112 lines, -0 lines 0 comments Download
A remoting/host/security_key/remote_security_key_ipc_client.cc View 1 chunk +222 lines, -0 lines 0 comments Download
A remoting/host/security_key/remote_security_key_ipc_client_unittest.cc View 1 chunk +355 lines, -0 lines 0 comments Download
A remoting/host/security_key/remote_security_key_ipc_constants.h View 1 chunk +29 lines, -0 lines 0 comments Download
A remoting/host/security_key/remote_security_key_ipc_constants.cc View 1 chunk +49 lines, -0 lines 0 comments Download
A remoting/host/security_key/remote_security_key_ipc_server.h View 1 chunk +61 lines, -0 lines 0 comments Download
A remoting/host/security_key/remote_security_key_ipc_server.cc View 1 chunk +54 lines, -0 lines 0 comments Download
A remoting/host/security_key/remote_security_key_ipc_server_impl.h View 1 chunk +98 lines, -0 lines 0 comments Download
A remoting/host/security_key/remote_security_key_ipc_server_impl.cc View 1 chunk +194 lines, -0 lines 0 comments Download
A remoting/host/security_key/remote_security_key_ipc_server_unittest.cc View 1 chunk +420 lines, -0 lines 0 comments Download
M remoting/host/security_key/remote_security_key_main.cc View 3 chunks +6 lines, -5 lines 0 comments Download
A remoting/host/security_key/remote_security_key_message_handler.h View 1 chunk +90 lines, -0 lines 0 comments Download
A remoting/host/security_key/remote_security_key_message_handler.cc View 1 chunk +184 lines, -0 lines 0 comments Download
A remoting/host/security_key/remote_security_key_message_handler_unittest.cc View 1 chunk +302 lines, -0 lines 0 comments Download
A remoting/host/security_key/remote_security_key_message_reader.h View 1 chunk +32 lines, -0 lines 0 comments Download
A remoting/host/security_key/remote_security_key_message_reader.cc View 1 chunk +134 lines, -0 lines 0 comments Download
A remoting/host/security_key/remote_security_key_message_reader_impl.h View 1 chunk +72 lines, -0 lines 0 comments Download
A remoting/host/security_key/remote_security_key_message_reader_impl.cc View 1 chunk +144 lines, -0 lines 0 comments Download
A remoting/host/security_key/remote_security_key_message_reader_impl_unittest.cc View 1 chunk +269 lines, -0 lines 0 comments Download
A remoting/host/security_key/remote_security_key_message_writer.h View 1 chunk +31 lines, -0 lines 0 comments Download
A remoting/host/security_key/remote_security_key_message_writer.cc View 1 chunk +82 lines, -0 lines 0 comments Download
A remoting/host/security_key/remote_security_key_message_writer_impl.h View 1 chunk +41 lines, -0 lines 0 comments Download
A remoting/host/security_key/remote_security_key_message_writer_impl.cc View 1 chunk +83 lines, -0 lines 0 comments Download
A remoting/host/security_key/remote_security_key_message_writer_impl_unittest.cc View 1 chunk +204 lines, -0 lines 0 comments Download
D remoting/host/security_key/security_key_auth_handler.h View 1 chunk +0 lines, -72 lines 0 comments Download
D remoting/host/security_key/security_key_auth_handler_android.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D remoting/host/security_key/security_key_auth_handler_linux.cc View 1 chunk +0 lines, -288 lines 0 comments Download
D remoting/host/security_key/security_key_auth_handler_linux_unittest.cc View 1 chunk +0 lines, -248 lines 0 comments Download
D remoting/host/security_key/security_key_auth_handler_mac.cc View 1 chunk +0 lines, -17 lines 0 comments Download
D remoting/host/security_key/security_key_auth_handler_win.cc View 1 chunk +0 lines, -307 lines 0 comments Download
D remoting/host/security_key/security_key_auth_handler_win_unittest.cc View 1 chunk +0 lines, -554 lines 0 comments Download
D remoting/host/security_key/security_key_extension.h View 1 chunk +0 lines, -37 lines 0 comments Download
D remoting/host/security_key/security_key_extension.cc View 1 chunk +0 lines, -37 lines 0 comments Download
D remoting/host/security_key/security_key_extension_session.h View 1 chunk +0 lines, -67 lines 0 comments Download
D remoting/host/security_key/security_key_extension_session.cc View 1 chunk +0 lines, -212 lines 0 comments Download
D remoting/host/security_key/security_key_extension_session_unittest.cc View 1 chunk +0 lines, -450 lines 0 comments Download
D remoting/host/security_key/security_key_ipc_client.h View 1 chunk +0 lines, -112 lines 0 comments Download
D remoting/host/security_key/security_key_ipc_client.cc View 1 chunk +0 lines, -221 lines 0 comments Download
D remoting/host/security_key/security_key_ipc_client_unittest.cc View 1 chunk +0 lines, -344 lines 0 comments Download
D remoting/host/security_key/security_key_ipc_constants.h View 1 chunk +0 lines, -29 lines 0 comments Download
D remoting/host/security_key/security_key_ipc_constants.cc View 1 chunk +0 lines, -45 lines 0 comments Download
D remoting/host/security_key/security_key_ipc_server.h View 1 chunk +0 lines, -61 lines 0 comments Download
D remoting/host/security_key/security_key_ipc_server.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D remoting/host/security_key/security_key_ipc_server_impl.h View 1 chunk +0 lines, -97 lines 0 comments Download
D remoting/host/security_key/security_key_ipc_server_impl.cc View 1 chunk +0 lines, -192 lines 0 comments Download
D remoting/host/security_key/security_key_ipc_server_unittest.cc View 1 chunk +0 lines, -409 lines 0 comments Download
M remoting/host/security_key/security_key_message.h View 2 chunks +7 lines, -7 lines 0 comments Download
M remoting/host/security_key/security_key_message.cc View 3 chunks +16 lines, -15 lines 0 comments Download
D remoting/host/security_key/security_key_message_handler.h View 1 chunk +0 lines, -89 lines 0 comments Download
D remoting/host/security_key/security_key_message_handler.cc View 1 chunk +0 lines, -181 lines 0 comments Download
D remoting/host/security_key/security_key_message_handler_unittest.cc View 1 chunk +0 lines, -299 lines 0 comments Download
D remoting/host/security_key/security_key_message_reader.h View 1 chunk +0 lines, -32 lines 0 comments Download
D remoting/host/security_key/security_key_message_reader.cc View 1 chunk +0 lines, -132 lines 0 comments Download
D remoting/host/security_key/security_key_message_reader_impl.h View 1 chunk +0 lines, -71 lines 0 comments Download
D remoting/host/security_key/security_key_message_reader_impl.cc View 1 chunk +0 lines, -143 lines 0 comments Download
D remoting/host/security_key/security_key_message_reader_impl_unittest.cc View 1 chunk +0 lines, -267 lines 0 comments Download
D remoting/host/security_key/security_key_message_writer.h View 1 chunk +0 lines, -30 lines 0 comments Download
D remoting/host/security_key/security_key_message_writer.cc View 1 chunk +0 lines, -81 lines 0 comments Download
D remoting/host/security_key/security_key_message_writer_impl.h View 1 chunk +0 lines, -40 lines 0 comments Download
D remoting/host/security_key/security_key_message_writer_impl.cc View 1 chunk +0 lines, -82 lines 0 comments Download
D remoting/host/security_key/security_key_message_writer_impl_unittest.cc View 1 chunk +0 lines, -202 lines 0 comments Download
D remoting/host/security_key/security_key_socket.h View 1 chunk +0 lines, -113 lines 0 comments Download
D remoting/host/security_key/security_key_socket.cc View 1 chunk +0 lines, -188 lines 0 comments Download
M remoting/remoting_host_srcs.gypi View 1 chunk +27 lines, -27 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
hayato
Created Revert of Renaming Gnubby and RemoteSecurityKey files/classes/members
4 years, 5 months ago (2016-07-20 01:29:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167473003/1
4 years, 5 months ago (2016-07-20 01:30:13 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 01:35:51 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 01:37:49 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a
Cr-Commit-Position: refs/heads/master@{#406440}

Powered by Google App Engine
This is Rietveld 408576698