Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: chrome/browser/resources/settings/internet_page/network_summary.html

Issue 2167473002: MD Settings: Internet: Reduce use of hidden for complex sections. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/internet_page/network_summary.html
diff --git a/chrome/browser/resources/settings/internet_page/network_summary.html b/chrome/browser/resources/settings/internet_page/network_summary.html
index 6ff7fd0d8ed6fb20c3a08068a2f733bb19d9fc9d..f71353853dae330d9680df4eb2942221ba919143 100644
--- a/chrome/browser/resources/settings/internet_page/network_summary.html
+++ b/chrome/browser/resources/settings/internet_page/network_summary.html
@@ -5,40 +5,17 @@
<dom-module id="network-summary">
<template>
<div id="summary" class="layout vertical">
- <network-summary-item id="ethernet"
- device-state="[[deviceStates.Ethernet]]"
- network-state="[[networkStates.Ethernet]]"
- network-state-list="[[networkStateLists.Ethernet]]"
- on-selected="onSelected_">
- </network-summary-item>
- <network-summary-item id="wifi"
- device-state="[[deviceStates.WiFi]]"
- network-state="[[networkStates.WiFi]]"
- network-state-list="[[networkStateLists.WiFi]]"
- on-expanded="onWiFiExpanded_"
- on-selected="onSelected_"
- on-device-enabled-toggled="onDeviceEnabledToggled_">
- </network-summary-item>
- <network-summary-item id="cellular"
- device-state="[[deviceStates.Cellular]]"
- network-state="[[networkStates.Cellular]]"
- network-state-list="[[networkStateLists.Cellular]]"
- on-selected="onSelected_"
- on-device-enabled-toggled="onDeviceEnabledToggled_">
- </network-summary-item>
- <network-summary-item id="wimax"
- device-state="[[deviceStates.WiMAX]]"
- network-state="[[networkStates.WiMAX]]"
- network-state-list="[[networkStateLists.WiMAX]]"
- on-selected="onSelected_"
- on-device-enabled-toggled="onDeviceEnabledToggled_">
- </network-summary-item>
- <network-summary-item id="vpn"
- device-state="[[deviceStates.VPN]]"
- network-state="[[networkStates.VPN]]"
- network-state-list="[[networkStateLists.VPN]]"
- on-selected="onSelected_">
- </network-summary-item>
+ <template is="dom-repeat" items="[[activeNetworkStates]]" as="item">
michaelpg 2016/07/20 19:36:37 as="item" is unnecessary (the default)
stevenjb 2016/07/20 20:29:16 Done.
+ <network-summary-item
+ id="[[item.Type]]"
+ active-network-state="[[item]]"
+ device-state="[[get(item.Type, deviceStates)]]"
+ network-state-list="[[get(item.Type, networkStateLists)]]"
+ on-expanded="onExpanded_"
+ on-selected="onSelected_"
+ on-device-enabled-toggled="onDeviceEnabledToggled_">
+ </network-summary-item>
+ </template>
</div>
</template>
<script src="network_summary.js"></script>

Powered by Google App Engine
This is Rietveld 408576698