chrome/browser/resources/settings/internet_page/network_summary.html - Issue 2167473002: MD Settings: Internet: Reduce use of hidden for complex sections.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/internet_page/network_summary.html

Issue 2167473002: MD Settings: Internet: Reduce use of hidden for complex sections. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/browser/resources/settings/internet_page/network_summary.js » ('j') | chrome/browser/resources/settings/internet_page/network_summary.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/html/polymer.html">	1 <link rel="import" href="chrome://resources/html/polymer.html">

2 <link rel="import" href="chrome://resources/cr_elements/network/cr_onc_types.htm l">	2 <link rel="import" href="chrome://resources/cr_elements/network/cr_onc_types.htm l">

3 <link rel="import" href="network_summary_item.html">	3 <link rel="import" href="network_summary_item.html">

4	4

5 <dom-module id="network-summary">	5 <dom-module id="network-summary">

6 <template>	6 <template>

7 <div id="summary" class="layout vertical">	7 <div id="summary" class="layout vertical">

8 <network-summary-item id="ethernet"	8 <template is="dom-repeat" items="[[activeNetworkStates]]" as="item">
	michaelpg 2016/07/20 19:36:37 as="item" is unnecessary (the default) as="item" is unnecessary (the default) stevenjb 2016/07/20 20:29:16 Done. Show quoted text On 2016/07/20 19:36:37, michaelpg wrote: > as="item" is unnecessary (the default) Done.
9 device-state="[[deviceStates.Ethernet]]"	9 <network-summary-item

10 network-state="[[networkStates.Ethernet]]"	10 id="[[item.Type]]"

11 network-state-list="[[networkStateLists.Ethernet]]"	11 active-network-state="[[item]]"

12 on-selected="onSelected_">	12 device-state="[[get(item.Type, deviceStates)]]"

13 </network-summary-item>	13 network-state-list="[[get(item.Type, networkStateLists)]]"

14 <network-summary-item id="wifi"	14 on-expanded="onExpanded_"

15 device-state="[[deviceStates.WiFi]]"	15 on-selected="onSelected_"

16 network-state="[[networkStates.WiFi]]"	16 on-device-enabled-toggled="onDeviceEnabledToggled_">

17 network-state-list="[[networkStateLists.WiFi]]"	17 </network-summary-item>

18 on-expanded="onWiFiExpanded_"	18 </template>

19 on-selected="onSelected_"

20 on-device-enabled-toggled="onDeviceEnabledToggled_">

21 </network-summary-item>

22 <network-summary-item id="cellular"

23 device-state="[[deviceStates.Cellular]]"

24 network-state="[[networkStates.Cellular]]"

25 network-state-list="[[networkStateLists.Cellular]]"

26 on-selected="onSelected_"

27 on-device-enabled-toggled="onDeviceEnabledToggled_">

28 </network-summary-item>

29 <network-summary-item id="wimax"

30 device-state="[[deviceStates.WiMAX]]"

31 network-state="[[networkStates.WiMAX]]"

32 network-state-list="[[networkStateLists.WiMAX]]"

33 on-selected="onSelected_"

34 on-device-enabled-toggled="onDeviceEnabledToggled_">

35 </network-summary-item>

36 <network-summary-item id="vpn"

37 device-state="[[deviceStates.VPN]]"

38 network-state="[[networkStates.VPN]]"

39 network-state-list="[[networkStateLists.VPN]]"

40 on-selected="onSelected_">

41 </network-summary-item>

42 </div>	19 </div>

43 </template>	20 </template>

44 <script src="network_summary.js"></script>	21 <script src="network_summary.js"></script>

45 </dom-module>	22 </dom-module>

OLD	NEW