Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 2167473002: MD Settings: Internet: Reduce use of hidden for complex sections. (Closed)

Created:
4 years, 5 months ago by stevenjb
Modified:
4 years, 5 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Internet: Reduce use of hidden for complex sections. This cleanup CL does the following: * Use dom-repeat to only include sections for existing device types. * Use dom-if instead of display to show items with infrequent visibility changes. * Minor layout / CSS cleanup. BUG=609156, 609002 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/b4c0d25b2cad8e2f3540f2d9b88607b5a74b339f Cr-Commit-Position: refs/heads/master@{#406890}

Patch Set 1 #

Patch Set 2 : Re-refactor #

Patch Set 3 : . #

Total comments: 13

Patch Set 4 : Feedback + wimax string fix #

Total comments: 2

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -217 lines) Patch
M chrome/browser/resources/settings/internet_page/network_summary.html View 1 2 3 4 1 chunk +10 lines, -34 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_summary.js View 1 2 3 12 chunks +64 lines, -97 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_summary_item.html View 1 3 chunks +31 lines, -24 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_summary_item.js View 1 2 3 7 chunks +26 lines, -61 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (10 generated)
stevenjb
4 years, 5 months ago (2016-07-19 18:57:32 UTC) #3
stevenjb
On 2016/07/19 18:57:32, stevenjb wrote: Er, hold off on this, I missed some stuff when ...
4 years, 5 months ago (2016-07-19 20:22:48 UTC) #6
stevenjb
OK, this ended up being a little more re-factoring all at once than I originally ...
4 years, 5 months ago (2016-07-19 23:10:01 UTC) #9
michaelpg
https://codereview.chromium.org/2167473002/diff/80001/chrome/browser/resources/settings/internet_page/network_summary.html File chrome/browser/resources/settings/internet_page/network_summary.html (right): https://codereview.chromium.org/2167473002/diff/80001/chrome/browser/resources/settings/internet_page/network_summary.html#newcode8 chrome/browser/resources/settings/internet_page/network_summary.html:8: <template is="dom-repeat" items="[[activeNetworkStates]]" as="item"> as="item" is unnecessary (the default) ...
4 years, 5 months ago (2016-07-20 19:36:37 UTC) #10
stevenjb
PTAL https://codereview.chromium.org/2167473002/diff/80001/chrome/browser/resources/settings/internet_page/network_summary.html File chrome/browser/resources/settings/internet_page/network_summary.html (right): https://codereview.chromium.org/2167473002/diff/80001/chrome/browser/resources/settings/internet_page/network_summary.html#newcode8 chrome/browser/resources/settings/internet_page/network_summary.html:8: <template is="dom-repeat" items="[[activeNetworkStates]]" as="item"> On 2016/07/20 19:36:37, michaelpg ...
4 years, 5 months ago (2016-07-20 20:29:16 UTC) #11
michaelpg
lgtm https://codereview.chromium.org/2167473002/diff/80001/chrome/browser/resources/settings/internet_page/network_summary_item.js File chrome/browser/resources/settings/internet_page/network_summary_item.js (right): https://codereview.chromium.org/2167473002/diff/80001/chrome/browser/resources/settings/internet_page/network_summary_item.js#newcode78 chrome/browser/resources/settings/internet_page/network_summary_item.js:78: console.log('activeNetwork: ' + JSON.stringify(this.activeNetworkState)); On 2016/07/20 20:29:16, stevenjb ...
4 years, 5 months ago (2016-07-20 23:52:37 UTC) #12
stevenjb
console.error is used like LOG(ERROR), not LOG(FATAL)/assert. It shouldn't every happen, but if it does ...
4 years, 5 months ago (2016-07-21 16:17:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167473002/120001
4 years, 5 months ago (2016-07-21 16:17:50 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:120001)
4 years, 5 months ago (2016-07-21 17:34:02 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 17:35:40 UTC) #20
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/b4c0d25b2cad8e2f3540f2d9b88607b5a74b339f
Cr-Commit-Position: refs/heads/master@{#406890}

Powered by Google App Engine
This is Rietveld 408576698