Add GrVkRecycledResource subclass

Add GrVkRecycledResource subclass

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167453003

Committed: https://skia.googlesource.com/skia/+/c1be9bc1696b50982eb6dda154a76f8dd7b7d438

[egdaniel, 2016-07-19 21:16:14]

Description was changed from

==========
Add GrVkRecycledResource subclass

BUG=skia:
==========

to

==========
Add GrVkRecycledResource subclass

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167453003
==========

[egdaniel, 2016-07-19 21:16:57]

egdaniel@google.com changed reviewers:
+ jvanverth@google.com

[egdaniel, 2016-07-19 21:17:06]

The CQ bit was checked by egdaniel@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 21:17:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 21:39:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 21:39:55]

Dry run: This issue passed the CQ dry run.

[egdaniel, 2016-07-20 13:39:49]

Now passes gpu into recycle

[jvanverth1, 2016-07-20 14:08:47]

https://codereview.chromium.org/2167453003/diff/20001/src/gpu/vk/GrVkCommandB...
File src/gpu/vk/GrVkCommandBuffer.cpp (right):

https://codereview.chromium.org/2167453003/diff/20001/src/gpu/vk/GrVkCommandB...
src/gpu/vk/GrVkCommandBuffer.cpp:60: // We don't recycle resources when
abadoning them.
sp: abandon

https://codereview.chromium.org/2167453003/diff/20001/src/gpu/vk/GrVkCommandB...
File src/gpu/vk/GrVkCommandBuffer.h (right):

https://codereview.chromium.org/2167453003/diff/20001/src/gpu/vk/GrVkCommandB...
src/gpu/vk/GrVkCommandBuffer.h:120: // Add ref-counted resource which can be
recycled that will be tracked and released when this
Nit: This comment is a little hard to parse. Maybe:
"Add ref-counted recyclable resource that will..."
or
"Add ref-counted resource that can be recycled. It will be tracked and ..."

https://codereview.chromium.org/2167453003/diff/20001/src/gpu/vk/GrVkResource.h
File src/gpu/vk/GrVkResource.h (right):

https://codereview.chromium.org/2167453003/diff/20001/src/gpu/vk/GrVkResource...
src/gpu/vk/GrVkResource.h:199: this->onRecycle(gpu);
Why not put the unref in here?

[egdaniel, 2016-07-20 14:48:40]

https://codereview.chromium.org/2167453003/diff/20001/src/gpu/vk/GrVkCommandB...
File src/gpu/vk/GrVkCommandBuffer.cpp (right):

https://codereview.chromium.org/2167453003/diff/20001/src/gpu/vk/GrVkCommandB...
src/gpu/vk/GrVkCommandBuffer.cpp:60: // We don't recycle resources when
abadoning them.
On 2016/07/20 14:08:47, jvanverth1 wrote:
> sp: abandon

Done.

https://codereview.chromium.org/2167453003/diff/20001/src/gpu/vk/GrVkCommandB...
File src/gpu/vk/GrVkCommandBuffer.h (right):

https://codereview.chromium.org/2167453003/diff/20001/src/gpu/vk/GrVkCommandB...
src/gpu/vk/GrVkCommandBuffer.h:120: // Add ref-counted resource which can be
recycled that will be tracked and released when this
On 2016/07/20 14:08:47, jvanverth1 wrote:
> Nit: This comment is a little hard to parse. Maybe:
> "Add ref-counted recyclable resource that will..."
> or
> "Add ref-counted resource that can be recycled. It will be tracked and ..."

Done.

https://codereview.chromium.org/2167453003/diff/20001/src/gpu/vk/GrVkResource.h
File src/gpu/vk/GrVkResource.h (right):

https://codereview.chromium.org/2167453003/diff/20001/src/gpu/vk/GrVkResource...
src/gpu/vk/GrVkResource.h:199: this->onRecycle(gpu);
On 2016/07/20 14:08:47, jvanverth1 wrote:
> Why not put the unref in here?

Done.

[jvanverth1, 2016-07-20 14:51:36]

lgtm

https://codereview.chromium.org/2167453003/diff/40001/src/gpu/vk/GrVkCommandB...
File src/gpu/vk/GrVkCommandBuffer.cpp (right):

https://codereview.chromium.org/2167453003/diff/40001/src/gpu/vk/GrVkCommandB...
src/gpu/vk/GrVkCommandBuffer.cpp:73: fTrackedRecycledResources[i]->unref(gpu);
I think you have an extra unref here.

[egdaniel, 2016-07-20 14:53:26]

https://codereview.chromium.org/2167453003/diff/40001/src/gpu/vk/GrVkCommandB...
File src/gpu/vk/GrVkCommandBuffer.cpp (right):

https://codereview.chromium.org/2167453003/diff/40001/src/gpu/vk/GrVkCommandB...
src/gpu/vk/GrVkCommandBuffer.cpp:73: fTrackedRecycledResources[i]->unref(gpu);
On 2016/07/20 14:51:36, jvanverth1 wrote:
> I think you have an extra unref here.

Done.

[egdaniel, 2016-07-20 14:53:31]

The CQ bit was checked by egdaniel@google.com

[egdaniel, 2016-07-20 14:53:31]

The patchset sent to the CQ was uploaded after l-g-t-m from jvanverth@google.com
Link to the patchset: https://codereview.chromium.org/2167453003/#ps60001
(title: "remove extra unref")

[commit-bot: I haz the power, 2016-07-20 14:53:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 15:33:02]

Description was changed from

==========
Add GrVkRecycledResource subclass

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167453003
==========

to

==========
Add GrVkRecycledResource subclass

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167453003

Committed:
https://skia.googlesource.com/skia/+/c1be9bc1696b50982eb6dda154a76f8dd7b7d438
==========

[commit-bot: I haz the power, 2016-07-20 15:33:03]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/c1be9bc1696b50982eb6dda154a76f8dd7b7d438