Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Unified Diff: ash/shell.cc

Issue 216743004: Prevent system modal dialog from blocking events to the virtual keyboard. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/shell.cc
diff --git a/ash/shell.cc b/ash/shell.cc
index 4c12d322a5359dd7e30e1f257cfeeea142a2d0c2..c3b0c7d20856f01e5232a01943dfccd3c32fe730 100644
--- a/ash/shell.cc
+++ b/ash/shell.cc
@@ -1086,6 +1086,14 @@ bool Shell::CanWindowReceiveEvents(aura::Window* window) {
if (layout_manager && layout_manager->CanWindowReceiveEvents(window))
return true;
}
+
+ // Allow events to fall through to the virtual keyboard even if displaying
+ // a system modal dialog.
+ aura::Window* keyboard_container = GetPrimaryRootWindowController()->
+ GetContainer(internal::kShellWindowId_VirtualKeyboardParentContainer);
+ if (keyboard_container && keyboard_container->Contains(window))
oshima 2014/03/28 16:55:15 Will keyboard_contorller->GetContainerWindow()->C
kevers 2014/03/28 17:52:37 keyboard_controller->GetContainerWindow() has side
oshima 2014/03/28 20:02:42 If that's the case, can you check this in RWC (say
kevers 2014/03/28 21:11:00 Done.
+ return true;
+
return false;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698