Prevent system modal dialog from blocking events to the virtual keyboard.

ash/shell.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/shell.h"
 
 #include <algorithm>
 #include <string>
 
 #include "ash/accelerators/accelerator_controller.h"
@@ skipping 1068 matching lines @@
 
 bool Shell::CanWindowReceiveEvents(aura::Window* window) {
   RootWindowControllerList controllers = GetAllRootWindowControllers();
   for (RootWindowControllerList::iterator iter = controllers.begin();
        iter != controllers.end(); ++iter) {
     internal::SystemModalContainerLayoutManager* layout_manager =
         (*iter)->GetSystemModalLayoutManager(window);
     if (layout_manager && layout_manager->CanWindowReceiveEvents(window))
       return true;
   }
+
+  // Allow events to fall through to the virtual keyboard even if displaying
+  // a system modal dialog.
+  aura::Window* keyboard_container = GetPrimaryRootWindowController()->
+      GetContainer(internal::kShellWindowId_VirtualKeyboardParentContainer);
+  if (keyboard_container && keyboard_container->Contains(window))

[oshima, 2014/03/28 16:55:15]

Will

keyboard_contorller->GetContainerWindow()->Contains(window)

work?

[kevers, 2014/03/28 17:52:37]

keyboard_controller->GetContainerWindow() has side effects creating the keyboard
window if it does not already exist.

[oshima, 2014/03/28 20:02:42]

If that's the case, can you check this in RWC (say
RWC::IsVirtualkeyboardWindow(aura::Window*)) and check it in the loop above?
Currently, only RWC knows about the virtual keyboard container and it'd be
better to keep it that way.

[kevers, 2014/03/28 21:11:00]

Done.

+    return true;
+
   return false;
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // Shell, ui::EventTarget overrides:
 
 bool Shell::CanAcceptEvent(const ui::Event& event) {
   return true;
 }
 
@@ skipping 16 matching lines @@
 ////////////////////////////////////////////////////////////////////////////////
 // Shell, aura::client::ActivationChangeObserver implementation:
 
 void Shell::OnWindowActivated(aura::Window* gained_active,
                               aura::Window* lost_active) {
   if (gained_active)
     target_root_window_ = gained_active->GetRootWindow();
 }
 
 }  // namespace ash