ImageCapture: introduce image_capture Blob to allow move-only semantics

ImageCapture: introduce image_capture Blob to allow move-only semantics

https://crrev.com/2166713002 introduce usage of STL/WTF
types for image_capture. But that translated bindings of
 array<> to const std::vector<>& which forced strange
const_cast<>s to avoid copies.

This CL bundles mime_type and data into a mojo::Struct
that is move-only, hence avoiding the copies of, potentially
large, photo frames.

BUG=630040
Committed: https://crrev.com/431ae31e66ce1251570828f5a2c2773696774d58
Cr-Commit-Position: refs/heads/master@{#407333}

[mcasas, 2016-07-21 19:21:51]

Patchset #1 (id:1) has been deleted

[mcasas, 2016-07-21 22:20:02]

Patchset #1 (id:20001) has been deleted

[mcasas, 2016-07-21 22:23:35]

Description was changed from

==========
ImageCapture: introduce mojom::Blob as move-only type for the taken Photo



BUG=630040
==========

to

==========
ImageCapture: introduce image_capture Blob to allow move-only semantics

BUG=630040
==========

[mcasas, 2016-07-21 22:23:48]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 22:25:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mcasas, 2016-07-21 22:49:25]

Description was changed from

==========
ImageCapture: introduce image_capture Blob to allow move-only semantics

BUG=630040
==========

to

==========
ImageCapture: introduce image_capture Blob to allow move-only semantics

https://crrev.com/2166713002 introduce usage of STL/WTF
types for image_capture. But that translated bindings of
 array<> to const std::vector<>& which forced strange 
const_cast<>s to avoid copies.

This CL bundles mime_type and data into a mojo::Struct
that is move-only, hence avoiding the copies of, potentially
large, photo frames.

BUG=630040
==========

[mcasas, 2016-07-21 23:03:56]

mcasas@chromium.org changed reviewers:
+ yzshen@chromium.org

[mcasas, 2016-07-21 23:03:57]

yzshen@ PTAL

(finally managed to get the LayoutTests to work; it was,
indeed, a silly mistake on my part).

[commit-bot: I haz the power, 2016-07-22 01:28:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 01:28:49]

Dry run: This issue passed the CQ dry run.

[yzshen1, 2016-07-22 19:06:57]

lgtm

[mcasas, 2016-07-22 21:03:30]

mcasas@chromium.org changed reviewers:
+ foolip@chromium.org, wez@chromium.org

[mcasas, 2016-07-22 21:03:30]

wez@ image_capture_impl.cc please

foolip@ WebKit changes plz

[Wez, 2016-07-22 22:11:38]

image_capture_impl.cc LGTM

[foolip, 2016-07-22 23:35:19]

WebKit RS LGTM

https://codereview.chromium.org/2167313002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/imagecapture/takephoto.html (right):

https://codereview.chromium.org/2167313002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/imagecapture/takephoto.html:33:
assert_true('image/cat' === blob.type);
assert_equals(blob.type, 'image/cat') for better error messages on failure

https://codereview.chromium.org/2167313002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/imagecapture/takephoto.html:34:
assert_true(blob.size > 0);
assert_equals(blob.size, 2)

[Tom Sepez, 2016-07-23 01:08:35]

tsepez@chromium.org changed reviewers:
+ tsepez@chromium.org

[Tom Sepez, 2016-07-23 01:08:35]

mojom lgtm

[mcasas, 2016-07-23 02:32:08]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2016-07-23 02:32:08]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
yzshen@chromium.org, wez@chromium.org, foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2167313002/#ps60001
(title: "foolip comments and rebase")

[commit-bot: I haz the power, 2016-07-23 02:32:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mcasas, 2016-07-23 02:58:10]

https://codereview.chromium.org/2167313002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/imagecapture/takephoto.html (right):

https://codereview.chromium.org/2167313002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/imagecapture/takephoto.html:33:
assert_true('image/cat' === blob.type);
On 2016/07/22 23:35:18, foolip wrote:
> assert_equals(blob.type, 'image/cat') for better error messages on failure

Done.

https://codereview.chromium.org/2167313002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/imagecapture/takephoto.html:34:
assert_true(blob.size > 0);
On 2016/07/22 23:35:18, foolip wrote:
> assert_equals(blob.size, 2)

Done.

[commit-bot: I haz the power, 2016-07-23 03:30:49]

Description was changed from

==========
ImageCapture: introduce image_capture Blob to allow move-only semantics

https://crrev.com/2166713002 introduce usage of STL/WTF
types for image_capture. But that translated bindings of
 array<> to const std::vector<>& which forced strange 
const_cast<>s to avoid copies.

This CL bundles mime_type and data into a mojo::Struct
that is move-only, hence avoiding the copies of, potentially
large, photo frames.

BUG=630040
==========

to

==========
ImageCapture: introduce image_capture Blob to allow move-only semantics

https://crrev.com/2166713002 introduce usage of STL/WTF
types for image_capture. But that translated bindings of
 array<> to const std::vector<>& which forced strange 
const_cast<>s to avoid copies.

This CL bundles mime_type and data into a mojo::Struct
that is move-only, hence avoiding the copies of, potentially
large, photo frames.

BUG=630040
==========

[commit-bot: I haz the power, 2016-07-23 03:30:51]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-07-23 03:34:12]

Description was changed from

==========
ImageCapture: introduce image_capture Blob to allow move-only semantics

https://crrev.com/2166713002 introduce usage of STL/WTF
types for image_capture. But that translated bindings of
 array<> to const std::vector<>& which forced strange 
const_cast<>s to avoid copies.

This CL bundles mime_type and data into a mojo::Struct
that is move-only, hence avoiding the copies of, potentially
large, photo frames.

BUG=630040
==========

to

==========
ImageCapture: introduce image_capture Blob to allow move-only semantics

https://crrev.com/2166713002 introduce usage of STL/WTF
types for image_capture. But that translated bindings of
 array<> to const std::vector<>& which forced strange
const_cast<>s to avoid copies.

This CL bundles mime_type and data into a mojo::Struct
that is move-only, hence avoiding the copies of, potentially
large, photo frames.

BUG=630040

Committed: https://crrev.com/431ae31e66ce1251570828f5a2c2773696774d58
Cr-Commit-Position: refs/heads/master@{#407333}
==========

[commit-bot: I haz the power, 2016-07-23 03:34:14]

Patchset 2 (id:??) landed as
https://crrev.com/431ae31e66ce1251570828f5a2c2773696774d58
Cr-Commit-Position: refs/heads/master@{#407333}