Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp

Issue 2167313002: ImageCapture: introduce image_capture Blob to allow move-only semantics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: foolip comments and rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp
diff --git a/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp b/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp
index 9512117cf9fa32276ad1b0780cc7459372f5a957..cb553dd8f8705d922025d987902141800224ac3c 100644
--- a/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp
+++ b/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp
@@ -230,15 +230,16 @@ void ImageCapture::onSetOptions(ScriptPromiseResolver* resolver, bool result)
m_serviceRequests.remove(resolver);
}
-void ImageCapture::onTakePhoto(ScriptPromiseResolver* resolver, const String& mimeType, const Vector<uint8_t>& data)
+void ImageCapture::onTakePhoto(ScriptPromiseResolver* resolver, media::mojom::blink::BlobPtr blob)
{
if (!m_serviceRequests.contains(resolver))
return;
- if (data.isEmpty())
+ // TODO(mcasas): Should be using a mojo::StructTraits.
+ if (blob->data.isEmpty())
resolver->reject(DOMException::create(UnknownError, "platform error"));
else
- resolver->resolve(Blob::create(data.data(), data.size(), mimeType));
+ resolver->resolve(Blob::create(blob->data.data(), blob->data.size(), blob->mime_type));
m_serviceRequests.remove(resolver);
}

Powered by Google App Engine
This is Rietveld 408576698