Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2167233002: [Autofill] Remove ifdef for iOS (Closed)

Created:
4 years, 5 months ago by Mathieu
Modified:
4 years, 5 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, rouslan+autofill_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org, jdonnelly+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] Remove ifdef for iOS iOS Autofill uses the different AutofillClientIOS BUG=626383 Committed: https://crrev.com/f0f7ccc063123d306b5cc5f8c48fccff3547c83a Cr-Commit-Position: refs/heads/master@{#406899}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M chrome/browser/ui/autofill/chrome_autofill_client.cc View 2 chunks +2 lines, -9 lines 2 comments Download

Messages

Total messages: 12 (6 generated)
Mathieu
Hi Evan, PTAL!
4 years, 5 months ago (2016-07-21 17:23:27 UTC) #4
Evan Stade
lgtm https://codereview.chromium.org/2167233002/diff/1/chrome/browser/ui/autofill/chrome_autofill_client.cc File chrome/browser/ui/autofill/chrome_autofill_client.cc (right): https://codereview.chromium.org/2167233002/diff/1/chrome/browser/ui/autofill/chrome_autofill_client.cc#newcode347 chrome/browser/ui/autofill/chrome_autofill_client.cc:347: #if !defined(OS_ANDROID) should this actually be ANDROID_JAVA_UI?
4 years, 5 months ago (2016-07-21 17:34:33 UTC) #5
Mathieu
Thanks, submitting https://codereview.chromium.org/2167233002/diff/1/chrome/browser/ui/autofill/chrome_autofill_client.cc File chrome/browser/ui/autofill/chrome_autofill_client.cc (right): https://codereview.chromium.org/2167233002/diff/1/chrome/browser/ui/autofill/chrome_autofill_client.cc#newcode347 chrome/browser/ui/autofill/chrome_autofill_client.cc:347: #if !defined(OS_ANDROID) On 2016/07/21 17:34:33, Evan Stade ...
4 years, 5 months ago (2016-07-21 17:55:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167233002/1
4 years, 5 months ago (2016-07-21 17:56:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 18:04:15 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 18:07:19 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f0f7ccc063123d306b5cc5f8c48fccff3547c83a
Cr-Commit-Position: refs/heads/master@{#406899}

Powered by Google App Engine
This is Rietveld 408576698