Chromium Code Reviews| Index: chrome/browser/ui/autofill/chrome_autofill_client.cc |
| diff --git a/chrome/browser/ui/autofill/chrome_autofill_client.cc b/chrome/browser/ui/autofill/chrome_autofill_client.cc |
| index a297373e01503eeabff6a5dc59edb1204b7b87b2..e9d87562a8b12e079bc893994071e8c0457f3528 100644 |
| --- a/chrome/browser/ui/autofill/chrome_autofill_client.cc |
| +++ b/chrome/browser/ui/autofill/chrome_autofill_client.cc |
| @@ -344,11 +344,7 @@ bool ChromeAutofillClient::IsContextSecure(const GURL& form_origin) { |
| } |
| bool ChromeAutofillClient::ShouldShowSigninPromo() { |
| -#if defined(OS_IOS) |
| - // TODO(crbug.com/626383): Implement signin promo for iOS by changing the |
| - // logic of StartSigninFlow() below. |
| - return false; |
| -#elif !defined(OS_ANDROID) |
| +#if !defined(OS_ANDROID) |
|
Evan Stade
2016/07/21 17:34:33
should this actually be ANDROID_JAVA_UI?
Mathieu
2016/07/21 17:55:50
I've asked, and both dfalcantara and tedchoc agree
|
| // Determine if we are in a valid context (on desktop platforms, we could be |
| // in an app window with no Browser). |
| if (!chrome::FindBrowserWithWebContents(web_contents())) |
| @@ -360,10 +356,7 @@ bool ChromeAutofillClient::ShouldShowSigninPromo() { |
| } |
| void ChromeAutofillClient::StartSigninFlow() { |
| -// See ShouldShowSigninPromo. |
| -#if defined(OS_IOS) |
| - return; |
| -#elif defined(OS_ANDROID) |
| +#if defined(OS_ANDROID) |
| chrome::android::SigninPromoUtilAndroid::StartAccountSigninActivityForPromo( |
| content::ContentViewCore::FromWebContents(web_contents()), |
| signin_metrics::AccessPoint::ACCESS_POINT_AUTOFILL_DROPDOWN); |