Basic standalone GN configs.

Basic standalone GN configs.

This sketches out what a world without Chrome's GN configs would look like.

Instead of DEPSing in build/, we now host our own gypi_to_gn.py.

The symlink from skia/ to . lets us run gclient hooks when the .gclient file is in the directory above skia/ or inside skia/.  That means we don't need gn.py anymore.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167163002

Committed: https://skia.googlesource.com/skia/+/7fbfbbe8f435fde7233c78f4f2dd1efb4fdd324c

[mtklein_C, 2016-07-21 14:18:56]

Description was changed from

==========
Basic standalone GN configs.

This sketches out what a world without Chrome's GN configs would look like.
We still DEPS in build/, only for gypi_to_gn.py.

BUG=skia:
==========

to

==========
Basic standalone GN configs.

This sketches out what a world without Chrome's GN configs would look like.
We still DEPS in build/, only for gypi_to_gn.py.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167163002
==========

[mtklein_C, 2016-07-21 14:22:26]

mtklein@chromium.org changed reviewers:
+ jcgregorio@google.com

[mtklein_C, 2016-07-21 14:22:27]

For reference, to provoke thought, etc.  I'm not sold on pulling this trigger.

I hacked this up on a Mac, so Linux might not work out of the box.

[jcgregorio, 2016-07-21 15:30:29]

On 2016/07/21 at 14:22:27, mtklein wrote:
> For reference, to provoke thought, etc.  I'm not sold on pulling this trigger.
> 
> I hacked this up on a Mac, so Linux might not work out of the box.

Certainly seems less magical.

[mtklein_C, 2016-07-21 17:18:37]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 17:18:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 17:20:15]

The CQ bit was unchecked by commit-bot@chromium.org

[mtklein_C, 2016-07-21 17:20:16]

Description was changed from

==========
Basic standalone GN configs.

This sketches out what a world without Chrome's GN configs would look like.
We still DEPS in build/, only for gypi_to_gn.py.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167163002
==========

to

==========
Basic standalone GN configs.

This sketches out what a world without Chrome's GN configs would look like.

Instead of DEPSing in build/, we now just host our own copy of gypi_to_gn.py.

gn.py goes away in favor of DEPS hooks.  This is a fun solution: if we symlink
skia to ., that means skia/buildtools/... is always the right path, no matter if
.gclient is next to DEPS or one level up.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167163002
==========

[commit-bot: I haz the power, 2016-07-21 17:20:16]

Dry run: Try jobs failed on following builders:
  skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[mtklein_C, 2016-07-21 17:21:59]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 17:22:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein_C, 2016-07-21 17:34:42]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 17:34:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein_C, 2016-07-21 17:36:54]

Description was changed from

==========
Basic standalone GN configs.

This sketches out what a world without Chrome's GN configs would look like.
We still DEPS in build/, only for gypi_to_gn.py.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167163002
==========

to

==========
Basic standalone GN configs.

This sketches out what a world without Chrome's GN configs would look like.

Instead of DEPSing in build/, we now host our own gypi_to_gn.py.

The symlink from skia/ to . lets us run gclient hooks when the .gclient file is
in the directory above skia/ or inside skia/.  That means we don't need gn.py
any more.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167163002
==========

[mtklein_C, 2016-07-21 17:37:03]

Description was changed from

==========
Basic standalone GN configs.

This sketches out what a world without Chrome's GN configs would look like.

Instead of DEPSing in build/, we now host our own gypi_to_gn.py.

The symlink from skia/ to . lets us run gclient hooks when the .gclient file is
in the directory above skia/ or inside skia/.  That means we don't need gn.py
any more.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167163002
==========

to

==========
Basic standalone GN configs.

This sketches out what a world without Chrome's GN configs would look like.

Instead of DEPSing in build/, we now host our own gypi_to_gn.py.

The symlink from skia/ to . lets us run gclient hooks when the .gclient file is
in the directory above skia/ or inside skia/.  That means we don't need gn.py
anymore.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167163002
==========

[mtklein_C, 2016-07-21 17:39:35]

PTAL at PS 6.  I think I'm leaning pretty seriously towards landing this now. 
Certainly much less magical.

[commit-bot: I haz the power, 2016-07-21 18:00:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 18:00:25]

Dry run: This issue passed the CQ dry run.

[jcgregorio, 2016-07-21 18:51:56]

LGTM, with a couple questions and a typo in a file that was copied over, so not
sure if we bother to fix it.

https://codereview.chromium.org/2167163002/diff/100001/gn/BUILDCONFIG.gn
File gn/BUILDCONFIG.gn (right):

https://codereview.chromium.org/2167163002/diff/100001/gn/BUILDCONFIG.gn#newc...
gn/BUILDCONFIG.gn:1: # Copyright 2016 Google Inc.
Does BUILDCONFIG.gn implicitly load the BUILD.gn in the same directory?

https://codereview.chromium.org/2167163002/diff/100001/gn/gn_helpers.py
File gn/gn_helpers.py (right):

https://codereview.chromium.org/2167163002/diff/100001/gn/gn_helpers.py#newcode8
gn/gn_helpers.py:8: serialized GN veriables and Python variables.
variables

https://codereview.chromium.org/2167163002/diff/100001/skia
File skia (right):

https://codereview.chromium.org/2167163002/diff/100001/skia#newcode1
skia:1: .
Where is this used?

[mtklein, 2016-07-21 19:24:34]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2016-07-21 19:24:35]

https://codereview.chromium.org/2167163002/diff/100001/gn/BUILDCONFIG.gn
File gn/BUILDCONFIG.gn (right):

https://codereview.chromium.org/2167163002/diff/100001/gn/BUILDCONFIG.gn#newc...
gn/BUILDCONFIG.gn:1: # Copyright 2016 Google Inc.
On 2016/07/21 18:51:56, jcgregorio wrote:
> Does BUILDCONFIG.gn implicitly load the BUILD.gn in the same directory?

Nope, but that's what we're getting when we use targets like "//gn:default". 
Every access to gn/BUILD.gn from this file is explicit through a target path
like that.

https://codereview.chromium.org/2167163002/diff/100001/gn/gn_helpers.py
File gn/gn_helpers.py (right):

https://codereview.chromium.org/2167163002/diff/100001/gn/gn_helpers.py#newcode8
gn/gn_helpers.py:8: serialized GN veriables and Python variables.
On 2016/07/21 18:51:56, jcgregorio wrote:
> variables

Yeah, I didn't even read this file except where necessary to get past pylint
(changing a couple variable names to not clobber builtins).  

Let's leave it alone?

https://codereview.chromium.org/2167163002/diff/100001/skia
File skia (right):

https://codereview.chromium.org/2167163002/diff/100001/skia#newcode1
skia:1: .
On 2016/07/21 18:51:56, jcgregorio wrote:
> Where is this used?

This is the symlink that makes the hooks work from both skia/ and skia/..

[mtklein, 2016-07-21 19:24:46]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2016-07-21 19:24:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 19:25:47]

Description was changed from

==========
Basic standalone GN configs.

This sketches out what a world without Chrome's GN configs would look like.

Instead of DEPSing in build/, we now host our own gypi_to_gn.py.

The symlink from skia/ to . lets us run gclient hooks when the .gclient file is
in the directory above skia/ or inside skia/.  That means we don't need gn.py
anymore.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167163002
==========

to

==========
Basic standalone GN configs.

This sketches out what a world without Chrome's GN configs would look like.

Instead of DEPSing in build/, we now host our own gypi_to_gn.py.

The symlink from skia/ to . lets us run gclient hooks when the .gclient file is
in the directory above skia/ or inside skia/.  That means we don't need gn.py
anymore.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167163002

Committed:
https://skia.googlesource.com/skia/+/7fbfbbe8f435fde7233c78f4f2dd1efb4fdd324c
==========

[commit-bot: I haz the power, 2016-07-21 19:25:48]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/7fbfbbe8f435fde7233c78f4f2dd1efb4fdd324c