Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/third_party.gni

Issue 2167163002: Basic standalone GN configs. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: fmt Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« skia ('K') | « skia ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/third_party.gni
diff --git a/third_party/third_party.gni b/third_party/third_party.gni
index ede698c4afafd3e7d597b17edcfa44cb7fa82e69..d2583a9b7d5af4cdee8769e7e205748256ab85aa 100644
--- a/third_party/third_party.gni
+++ b/third_party/third_party.gni
@@ -9,13 +9,5 @@ template("third_party") {
# Warnings are just noise if we're not maintaining the code.
cflags = [ "-w" ]
-
- # Chrome's GN environment sets up a bunch of default configs we don't need/want here.
- configs -= [
- "//build/config/clang:extra_warnings",
- "//build/config/clang:find_bad_constructs",
- "//build/config/compiler:chromium_code",
- "//build/config:feature_flags",
- ]
}
}
« skia ('K') | « skia ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698