Soft hyphens with long suffix may add unnecessary hyphens

Soft hyphens with long suffix may add unnecessary hyphens

This patch fixes unnecessary hyphens appear when soft hyphens are used
and its suffix is too long to fit.

In that case, m_lineBreak is still pointing to the last break
opportunity, which is the beginning of the line, and the character
before is on the previous line.

Also, different code doing the same logic for when the word with soft
hyphen is at the end of a text node and is not are unified.

BUG=627715
Committed: https://crrev.com/33af59cf0bf37f84d6e6423442fc90ffa14176cd
Cr-Commit-Position: refs/heads/master@{#407025}

[kojii, 2016-07-21 08:03:53]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 08:04:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2016-07-21 08:23:17]

Description was changed from

==========
shy

BUG=
==========

to

==========
Soft hyphens with long suffix may add unnecessary hyphens

This patch fixes unnecessary hyphens appear when soft hyphens are used
and its suffix is too long to fit.

In that case, m_lineBreak is still pointing to the last break
oppoortunity, which is the beginning of the line, and the character
before is on the previous line.

BUG=627715
==========

[commit-bot: I haz the power, 2016-07-21 09:12:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 09:12:43]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kojii, 2016-07-21 17:35:55]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 17:36:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2016-07-21 17:37:13]

Description was changed from

==========
Soft hyphens with long suffix may add unnecessary hyphens

This patch fixes unnecessary hyphens appear when soft hyphens are used
and its suffix is too long to fit.

In that case, m_lineBreak is still pointing to the last break
oppoortunity, which is the beginning of the line, and the character
before is on the previous line.

BUG=627715
==========

to

==========
Soft hyphens with long suffix may add unnecessary hyphens

This patch fixes unnecessary hyphens appear when soft hyphens are used
and its suffix is too long to fit.

In that case, m_lineBreak is still pointing to the last break
opportunity, which is the beginning of the line, and the character
before is on the previous line.

Also, different code doing the same logic for when the word with soft
hyphen is at the end of a text node and is not are unified.

BUG=627715
==========

[kojii, 2016-07-21 18:30:35]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 18:31:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2016-07-21 20:05:27]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 20:05:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 20:18:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 20:18:34]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[kojii, 2016-07-21 21:56:45]

kojii@chromium.org changed reviewers:
+ eae@chromium.org

[kojii, 2016-07-21 21:56:46]

PTAL.

[eae, 2016-07-22 00:41:01]

Fixing a bug and simplifying the code? I like it!

LGTM

[eae, 2016-07-22 00:43:52]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2016-07-22 00:44:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 03:29:54]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-22 03:31:37]

Description was changed from

==========
Soft hyphens with long suffix may add unnecessary hyphens

This patch fixes unnecessary hyphens appear when soft hyphens are used
and its suffix is too long to fit.

In that case, m_lineBreak is still pointing to the last break
opportunity, which is the beginning of the line, and the character
before is on the previous line.

Also, different code doing the same logic for when the word with soft
hyphen is at the end of a text node and is not are unified.

BUG=627715
==========

to

==========
Soft hyphens with long suffix may add unnecessary hyphens

This patch fixes unnecessary hyphens appear when soft hyphens are used
and its suffix is too long to fit.

In that case, m_lineBreak is still pointing to the last break
opportunity, which is the beginning of the line, and the character
before is on the previous line.

Also, different code doing the same logic for when the word with soft
hyphen is at the end of a text node and is not are unified.

BUG=627715

Committed: https://crrev.com/33af59cf0bf37f84d6e6423442fc90ffa14176cd
Cr-Commit-Position: refs/heads/master@{#407025}
==========

[commit-bot: I haz the power, 2016-07-22 03:31:38]

Patchset 4 (id:??) landed as
https://crrev.com/33af59cf0bf37f84d6e6423442fc90ffa14176cd
Cr-Commit-Position: refs/heads/master@{#407025}