Soft hyphens with long suffix may add unnecessary hyphens

third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

 /*
  * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2003, 2004, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All right reserved.
  * Copyright (C) 2010 Google Inc. All rights reserved.
  * Copyright (C) 2013 Adobe Systems Incorporated.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 105 matching lines @@
 
 private:
     void skipTrailingWhitespace(InlineIterator&, const LineInfo&);
     bool shouldMidWordBreak(UChar, LineLayoutText, const Font&,
         float& charWidth, float& widthFromLastBreakingOpportunity,
         bool breakAll, int& nextBreakablePositionForBreakAll);
     bool rewindToMidWordBreak(WordMeasurement&, int end, float width);
     bool rewindToFirstMidWordBreak(LineLayoutText, const ComputedStyle&, const Font&, bool breakAll, WordMeasurement&);
     bool rewindToMidWordBreak(LineLayoutText, const ComputedStyle&, const Font&, bool breakAll, WordMeasurement&);
     bool hyphenate(LineLayoutText, const ComputedStyle&, const Font&, const Hyphenation&, float lastSpaceWordSpacing, WordMeasurement&);
+    bool isBreakAtSoftHyphen() const;
 
     InlineBidiResolver& m_resolver;
 
     InlineIterator m_current;
     InlineIterator m_lineBreak;
     InlineIterator m_startOfIgnoredSpaces;
 
     LineLayoutBlockFlow m_block;
     LineLayoutItem m_lastObject;
     LineLayoutItem m_nextObject;
@@ skipping 554 matching lines @@
     if (!prefixLength || prefixLength < Hyphenation::minimumPrefixLength)
         return false;
 
     // TODO(kojii): getCharacterRange() measures as if the word were not broken
     // as defined in the spec, and is faster than measuring each fragment, but
     // ignores the kerning between the last letter and the hyphen.
     return rewindToMidWordBreak(wordMeasurement, start + prefixLength,
         font.getCharacterRange(run, 0, prefixLength).width() + hyphenWidth);
 }
 
+ALWAYS_INLINE bool BreakingContext::isBreakAtSoftHyphen() const
+{
+    return m_lineBreak != m_resolver.position()
+        ? m_lineBreak.previousInSameNode() == softHyphenCharacter
+        : m_current.previousInSameNode() == softHyphenCharacter;
+}
+
 inline bool BreakingContext::handleText(WordMeasurements& wordMeasurements, bool& hyphenated)
 {
     if (!m_current.offset())
         m_appliedStartWidth = false;
 
     LineLayoutText layoutText(m_current.getLineLayoutItem());
 
     // If we have left a no-wrap inline and entered an autowrap inline while ignoring spaces
     // then we need to mark the start of the autowrap inline as a potential linebreak now.
     if (m_autoWrap && !ComputedStyle::autoWrap(m_lastWS) && m_ignoringSpaces) {
@@ skipping 266 matching lines @@
         if (hyphenation && (m_nextObject || m_lineInfo.isEmpty())) {
             m_width.addUncommittedWidth(-wordMeasurement.width);
             DCHECK(lastSpace == static_cast<unsigned>(wordMeasurement.startOffset));
             DCHECK(m_current.offset() == static_cast<unsigned>(wordMeasurement.endOffset));
             if (hyphenate(layoutText, style, font, *hyphenation, lastSpaceWordSpacing, wordMeasurement)) {
                 hyphenated = true;
                 m_atEnd = true;
             }
             m_width.addUncommittedWidth(wordMeasurement.width);
         }
-        if (!hyphenated
-            && m_lineBreak.previousInSameNode() == softHyphenCharacter
-            && !disableSoftHyphen) {
+        if (!hyphenated && isBreakAtSoftHyphen() && !disableSoftHyphen) {
             hyphenated = true;
             m_atEnd = true;
         }
     }
     return false;
 }
 
 inline void BreakingContext::prepareForNextCharacter(const LineLayoutText& layoutText, bool& prohibitBreakInside, bool previousCharacterIsSpace)
 {
     if (layoutText.isSVGInlineText() && m_current.offset()) {
@@ skipping 75 matching lines @@
     if (midWordBreak
         || trailingSpaceExceedsAvailableWidth(canBreakMidWord, layoutText, wordMeasurement, applyWordSpacing, wordSpacing, font)
         || !m_width.fitsOnLine()) {
         if (m_lineBreak.atTextParagraphSeparator()) {
             if (!stoppedIgnoringSpaces && m_current.offset() > 0)
                 m_lineMidpointState.ensureCharacterGetsLineBox(m_current);
             m_lineBreak.increment();
             m_lineInfo.setPreviousLineBrokeCleanly(true);
             wordMeasurement.endOffset = m_lineBreak.offset();
         }
-        if (m_lineBreak.getLineLayoutItem() && m_lineBreak.offset() && m_lineBreak.getLineLayoutItem().isText() && LineLayoutText(m_lineBreak.getLineLayoutItem()).textLength() && LineLayoutText(m_lineBreak.getLineLayoutItem()).characterAt(m_lineBreak.offset() - 1) == softHyphenCharacter && !disableSoftHyphen)
+        if (isBreakAtSoftHyphen() && !disableSoftHyphen)
             hyphenated = true;
         if (m_lineBreak.offset() && m_lineBreak.offset() != (unsigned)wordMeasurement.endOffset && !wordMeasurement.width) {
             if (charWidth) {
                 wordMeasurement.endOffset = m_lineBreak.offset();
                 wordMeasurement.width = charWidth;
             }
         }
         // Didn't fit. Jump to the end unless there's still an opportunity to collapse whitespace.
         if (m_ignoringSpaces || !m_collapseWhiteSpace || !m_currentCharacterIsSpace || !previousCharacterIsSpace) {
             m_atEnd = true;
@@ skipping 90 matching lines @@
 
     if (style.getTextIndentType() == TextIndentHanging)
         indentText = indentText == IndentText ? DoNotIndentText : IndentText;
 
     return indentText;
 }
 
 } // namespace blink
 
 #endif // BreakingContextInlineHeaders_h