Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2167063002: Renamed attach() to attachLayoutTree() in comments. (Closed)

Created:
4 years, 5 months ago by Bugs Nash
Modified:
4 years, 5 months ago
Reviewers:
nainar, esprehn
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renamed attach() to attachLayoutTree() in comments. Should have happened in https://codereview.chromium.org/2164493002 Committed: https://crrev.com/1844126492dbd6a6006459a9ef0e9cbfa6b18997 Cr-Commit-Position: refs/heads/master@{#406778}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/shadow/stale-distribution-after-shadow-removal.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLImageElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLObjectElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/ImageInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
Bugs Nash
4 years, 5 months ago (2016-07-21 02:53:12 UTC) #2
nainar
lgtm
4 years, 5 months ago (2016-07-21 02:53:58 UTC) #3
esprehn
lgtm
4 years, 5 months ago (2016-07-21 03:37:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167063002/1
4 years, 5 months ago (2016-07-21 04:17:15 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/99758) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, ...
4 years, 5 months ago (2016-07-21 04:22:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167063002/1
4 years, 5 months ago (2016-07-21 05:35:07 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 06:14:00 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 06:15:47 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1844126492dbd6a6006459a9ef0e9cbfa6b18997
Cr-Commit-Position: refs/heads/master@{#406778}

Powered by Google App Engine
This is Rietveld 408576698