Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Side by Side Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2167063002: Renamed attach() to attachLayoutTree() in comments. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
8 * (C) 2007 Eric Seidel (eric@webkit.org) 8 * (C) 2007 Eric Seidel (eric@webkit.org)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 1566 matching lines...) Expand 10 before | Expand all | Expand 10 after
1577 1577
1578 void Element::detach(const AttachContext& context) 1578 void Element::detach(const AttachContext& context)
1579 { 1579 {
1580 HTMLFrameOwnerElement::UpdateSuspendScope suspendWidgetHierarchyUpdates; 1580 HTMLFrameOwnerElement::UpdateSuspendScope suspendWidgetHierarchyUpdates;
1581 cancelFocusAppearanceUpdate(); 1581 cancelFocusAppearanceUpdate();
1582 removeCallbackSelectors(); 1582 removeCallbackSelectors();
1583 if (hasRareData()) { 1583 if (hasRareData()) {
1584 ElementRareData* data = elementRareData(); 1584 ElementRareData* data = elementRareData();
1585 data->clearPseudoElements(); 1585 data->clearPseudoElements();
1586 1586
1587 // attach() will clear the computed style for us when inside recalcStyle . 1587 // attachLayoutTree() will clear the computed style for us when inside r ecalcStyle.
1588 if (!document().inStyleRecalc()) 1588 if (!document().inStyleRecalc())
1589 data->clearComputedStyle(); 1589 data->clearComputedStyle();
1590 1590
1591 if (ElementAnimations* elementAnimations = data->elementAnimations()) { 1591 if (ElementAnimations* elementAnimations = data->elementAnimations()) {
1592 if (context.performingReattach) { 1592 if (context.performingReattach) {
1593 // FIXME: We call detach from within style recalc, so compositin gState is not up to date. 1593 // FIXME: We call detach from within style recalc, so compositin gState is not up to date.
1594 // https://code.google.com/p/chromium/issues/detail?id=339847 1594 // https://code.google.com/p/chromium/issues/detail?id=339847
1595 DisableCompositingQueryAsserts disabler; 1595 DisableCompositingQueryAsserts disabler;
1596 1596
1597 // FIXME: restart compositor animations rather than pull back to the main thread 1597 // FIXME: restart compositor animations rather than pull back to the main thread
(...skipping 2147 matching lines...) Expand 10 before | Expand all | Expand 10 after
3745 3745
3746 DEFINE_TRACE_WRAPPERS(Element) 3746 DEFINE_TRACE_WRAPPERS(Element)
3747 { 3747 {
3748 if (hasRareData()) { 3748 if (hasRareData()) {
3749 visitor->traceWrappers(elementRareData()); 3749 visitor->traceWrappers(elementRareData());
3750 } 3750 }
3751 ContainerNode::traceWrappers(visitor); 3751 ContainerNode::traceWrappers(visitor);
3752 } 3752 }
3753 3753
3754 } // namespace blink 3754 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698