Converted Observatory nav-notify element

Converted Observatory nav-notify element

Still writing tests.

R=johnmccutchan@google.com, rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/61e34b244bd76a8a13fb3dbbe21ec491461bc548

[cbernaschina, 2016-07-21 02:23:12]

cbernaschina@google.com changed reviewers:
+ johnmccutchan@google.com, rmacnak@google.com, turnidge@google.com

[Cutch, 2016-07-22 13:58:43]

https://codereview.chromium.org/2167053002/diff/20001/runtime/observatory/lib...
File runtime/observatory/lib/src/app/application.dart (right):

https://codereview.chromium.org/2167053002/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/app/application.dart:71: void
removePauseEvents(Isolate isolate) {
Should this method be on the NotificationRepository?

https://codereview.chromium.org/2167053002/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/app/application.dart:218: var remove =
notifications.list().where((notification) {
same question.

https://codereview.chromium.org/2167053002/diff/20001/runtime/observatory/lib...
File runtime/observatory/lib/src/models/objects/class.dart (right):

https://codereview.chromium.org/2167053002/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/models/objects/class.dart:5: part of models;
What is your plan to remove the duplication being introduced between the models
library and our object.dart library? It's a big burden to have three definitions
of the same objects. Which is the authoritative definition of these objects? Is
it in objects.dart or models.dart?

[cbernaschina, 2016-07-22 18:27:24]

https://codereview.chromium.org/2167053002/diff/20001/runtime/observatory/lib...
File runtime/observatory/lib/src/app/application.dart (right):

https://codereview.chromium.org/2167053002/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/app/application.dart:71: void
removePauseEvents(Isolate isolate) {
On 2016/07/22 13:58:43, Cutch wrote:
> Should this method be on the NotificationRepository?

Done.

https://codereview.chromium.org/2167053002/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/app/application.dart:218: var remove =
notifications.list().where((notification) {
On 2016/07/22 13:58:43, Cutch wrote:
> same question. 

Done.

[cbernaschina, 2016-07-22 18:29:50]

https://codereview.chromium.org/2167053002/diff/20001/runtime/observatory/lib...
File runtime/observatory/lib/src/models/objects/class.dart (right):

https://codereview.chromium.org/2167053002/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/models/objects/class.dart:5: part of models;
On 2016/07/22 13:58:43, Cutch wrote:
> What is your plan to remove the duplication being introduced between the
models
> library and our object.dart library? It's a big burden to have three
definitions
> of the same objects. Which is the authoritative definition of these objects?
Is
> it in objects.dart or models.dart?

The objects.dart objects cannot be changed right now because all the components
right now are relying in their structure. The models.dart are there to enforce
the structure and are the blueprint for the objects. Once polymer is removed
they can be integrated back in objects.dart

[Cutch, 2016-07-22 20:03:33]

lgtm

[rmacnak, 2016-07-23 00:23:51]

lgtm w/c

https://chromiumcodereview.appspot.com/2167053002/diff/80001/runtime/observat...
File runtime/observatory/lib/src/app/notification.dart (right):

https://chromiumcodereview.appspot.com/2167053002/diff/80001/runtime/observat...
runtime/observatory/lib/src/app/notification.dart:25: isolate: event.isolate);
Strange alignment.

When splitting arguments across lines, either align the subsequent lines to the
first argument (if there's room) or indent all subsequent lines four spaces.

https://chromiumcodereview.appspot.com/2167053002/diff/80001/runtime/observat...
File runtime/observatory/lib/src/mocks/objects/event.dart (right):

https://chromiumcodereview.appspot.com/2167053002/diff/80001/runtime/observat...
runtime/observatory/lib/src/mocks/objects/event.dart:96: const
BreakpointResolvedEventMock({this.timestamp, this.isolate, this.breakpoint});
long line

https://chromiumcodereview.appspot.com/2167053002/diff/80001/runtime/observat...
runtime/observatory/lib/src/mocks/objects/event.dart:102: const
BreakpointRemovedEventMock({this.timestamp, this.isolate, this.breakpoint});
long line

https://chromiumcodereview.appspot.com/2167053002/diff/80001/runtime/observat...
runtime/observatory/lib/src/mocks/objects/event.dart:132: const
TimelineEventsEventMock({this.timestamp, this.isolate, this.timelineEvents});
long line

https://chromiumcodereview.appspot.com/2167053002/diff/80001/runtime/observat...
File runtime/observatory/lib/src/mocks/objects/notification.dart (right):

https://chromiumcodereview.appspot.com/2167053002/diff/80001/runtime/observat...
runtime/observatory/lib/src/mocks/objects/notification.dart:7: class
ExceptionNotificationMock implements M.ExceptionNotification{
M.ExceptionNotification {

https://chromiumcodereview.appspot.com/2167053002/diff/80001/runtime/observat...
runtime/observatory/lib/src/mocks/objects/notification.dart:13: class
EventNotificationMock implements M.EventNotification{
M.EventNotification {

[cbernaschina, 2016-07-23 00:40:55]

https://codereview.chromium.org/2167053002/diff/80001/runtime/observatory/lib...
File runtime/observatory/lib/src/app/notification.dart (right):

https://codereview.chromium.org/2167053002/diff/80001/runtime/observatory/lib...
runtime/observatory/lib/src/app/notification.dart:25: isolate: event.isolate);
On 2016/07/23 00:23:50, rmacnak wrote:
> Strange alignment.
> 
> When splitting arguments across lines, either align the subsequent lines to
the
> first argument (if there's room) or indent all subsequent lines four spaces.

Done.

https://codereview.chromium.org/2167053002/diff/80001/runtime/observatory/lib...
File runtime/observatory/lib/src/mocks/objects/event.dart (right):

https://codereview.chromium.org/2167053002/diff/80001/runtime/observatory/lib...
runtime/observatory/lib/src/mocks/objects/event.dart:96: const
BreakpointResolvedEventMock({this.timestamp, this.isolate, this.breakpoint});
On 2016/07/23 00:23:50, rmacnak wrote:
> long line

Done.

https://codereview.chromium.org/2167053002/diff/80001/runtime/observatory/lib...
runtime/observatory/lib/src/mocks/objects/event.dart:102: const
BreakpointRemovedEventMock({this.timestamp, this.isolate, this.breakpoint});
On 2016/07/23 00:23:50, rmacnak wrote:
> long line

Done.

https://codereview.chromium.org/2167053002/diff/80001/runtime/observatory/lib...
runtime/observatory/lib/src/mocks/objects/event.dart:132: const
TimelineEventsEventMock({this.timestamp, this.isolate, this.timelineEvents});
On 2016/07/23 00:23:50, rmacnak wrote:
> long line

Done.

https://codereview.chromium.org/2167053002/diff/80001/runtime/observatory/lib...
File runtime/observatory/lib/src/mocks/objects/notification.dart (right):

https://codereview.chromium.org/2167053002/diff/80001/runtime/observatory/lib...
runtime/observatory/lib/src/mocks/objects/notification.dart:7: class
ExceptionNotificationMock implements M.ExceptionNotification{
On 2016/07/23 00:23:50, rmacnak wrote:
> M.ExceptionNotification {

Done.

https://codereview.chromium.org/2167053002/diff/80001/runtime/observatory/lib...
runtime/observatory/lib/src/mocks/objects/notification.dart:13: class
EventNotificationMock implements M.EventNotification{
On 2016/07/23 00:23:50, rmacnak wrote:
> M.EventNotification {

Done.

[cbernaschina, 2016-07-24 19:54:12]

Description was changed from

==========
Converted Observatory nav-notify element

Still writing tests.
==========

to

==========
Converted Observatory nav-notify element

Still writing tests.

R=johnmccutchan@google.com, rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/61e34b244bd76a8a13fb3dbbe21ec491461bc548
==========

[cbernaschina, 2016-07-24 19:54:14]

Committed patchset #10 (id:180001) manually as
61e34b244bd76a8a13fb3dbbe21ec491461bc548 (presubmit successful).