Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: runtime/observatory/lib/src/elements/nav_bar.dart

Issue 2167053002: Converted Observatory nav-notify element (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Fixed template ciclic references that were blocking initialization Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/nav_bar.dart
diff --git a/runtime/observatory/lib/src/elements/nav_bar.dart b/runtime/observatory/lib/src/elements/nav_bar.dart
index e27bf9ee149d2bed0b45e5fa8dd9ce4786a4effa..005a5d91d7dc75258d0063ab9be3ee4fb7e2c3db 100644
--- a/runtime/observatory/lib/src/elements/nav_bar.dart
+++ b/runtime/observatory/lib/src/elements/nav_bar.dart
@@ -4,10 +4,8 @@
library nav_bar_element;
-import 'dart:html' hide Notification;
import 'observatory_element.dart';
import 'package:observatory/service.dart';
-import 'package:observatory/app.dart' show Notification;
import 'package:polymer/polymer.dart';
@CustomTag('library-nav-menu')
@@ -17,52 +15,3 @@ class LibraryNavMenuElement extends ObservatoryElement {
LibraryNavMenuElement.created() : super.created();
}
-
-@CustomTag('nav-notify')
-class NavNotifyElement extends ObservatoryElement {
- @published ObservableList<Notification> notifications;
- @published bool notifyOnPause = true;
-
- NavNotifyElement.created() : super.created();
-}
-
-@CustomTag('nav-notify-event')
-class NavNotifyEventElement extends ObservatoryElement {
- @published ObservableList<Notification> notifications;
- @published Notification notification;
- @published ServiceEvent event;
- @published bool notifyOnPause = true;
-
- void closeItem(MouseEvent e, var detail, Element target) {
- notifications.remove(notification);
- }
-
- NavNotifyEventElement.created() : super.created();
-}
-
-@CustomTag('nav-notify-exception')
-class NavNotifyExceptionElement extends ObservatoryElement {
- @published ObservableList<Notification> notifications;
- @published Notification notification;
- @published var exception;
- @published var stacktrace;
-
- exceptionChanged() {
- notifyPropertyChange(#isNetworkError, true, false);
- notifyPropertyChange(#isUnexpectedError, true, false);
- }
-
- @observable get isNetworkError {
- return (exception is NetworkRpcException);
- }
-
- @observable get isUnexpectedError {
- return (exception is! NetworkRpcException);
- }
-
- void closeItem(MouseEvent e, var detail, Element target) {
- notifications.remove(notification);
- }
-
- NavNotifyExceptionElement.created() : super.created();
-}
« no previous file with comments | « runtime/observatory/lib/src/elements/nav/notify_wrapper.dart ('k') | runtime/observatory/lib/src/elements/nav_bar.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698