Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2167013002: bluetooth: Clean up bluez fake device name/alias code. (Closed)

Created:
4 years, 5 months ago by scheib
Modified:
4 years, 4 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, dbeam+watch-options_chromium.org, ortuno+watch_chromium.org, michaelpg+watch-options_chromium.org, scheib+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bt-GetName-
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Clean up bluez fake device name/alias code. Previously the fake devices were initialized with a mixture of constant strings and string literals. The naming was not consistant. This change uses a consistent pattern of: "Fake Device (name)" "Fake Device (alias)" "Paired Unconnectable Device (name)" "Paired Unconnectable Device (alias)" Committed: https://crrev.com/6c0bda3695e18fea15e2edc8470c5f8bbf8e47bf Cr-Commit-Position: refs/heads/master@{#410249}

Patch Set 1 #

Patch Set 2 : Merge TOT #

Patch Set 3 : fix patch dep #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M chrome/browser/ui/webui/options/chromeos/bluetooth_options_browsertest.js View 2 chunks +2 lines, -2 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_bluez_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_device_client.h View 2 chunks +2 lines, -0 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_device_client.cc View 4 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 27 (20 generated)
scheib
4 years, 4 months ago (2016-08-05 20:59:13 UTC) #11
scheib
4 years, 4 months ago (2016-08-05 21:00:09 UTC) #15
stevenjb
lgtm
4 years, 4 months ago (2016-08-05 21:05:26 UTC) #16
commit-bot: I haz the power
This CL has an open dependency (Issue 2167013002 Patch 1). Please resolve the dependency and ...
4 years, 4 months ago (2016-08-05 21:19:40 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167013002/40001
4 years, 4 months ago (2016-08-06 00:23:17 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-06 01:39:27 UTC) #25
commit-bot: I haz the power
4 years, 4 months ago (2016-08-06 01:42:45 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6c0bda3695e18fea15e2edc8470c5f8bbf8e47bf
Cr-Commit-Position: refs/heads/master@{#410249}

Powered by Google App Engine
This is Rietveld 408576698