Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Unified Diff: device/bluetooth/dbus/fake_bluetooth_device_client.cc

Issue 2167013002: bluetooth: Clean up bluez fake device name/alias code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bt-GetName-
Patch Set: fix patch dep Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/bluetooth/dbus/fake_bluetooth_device_client.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/bluetooth/dbus/fake_bluetooth_device_client.cc
diff --git a/device/bluetooth/dbus/fake_bluetooth_device_client.cc b/device/bluetooth/dbus/fake_bluetooth_device_client.cc
index 278e79b72b8db5fd261856a98f877b52516964ff..a2d60d0f1e465147d4d53f14964e4f03b5d09da5 100644
--- a/device/bluetooth/dbus/fake_bluetooth_device_client.cc
+++ b/device/bluetooth/dbus/fake_bluetooth_device_client.cc
@@ -148,7 +148,10 @@ const char FakeBluetoothDeviceClient::kPairingActionRequest[] = "Request";
const char FakeBluetoothDeviceClient::kPairedDevicePath[] = "/fake/hci0/dev0";
const char FakeBluetoothDeviceClient::kPairedDeviceAddress[] =
"00:11:22:33:44:55";
-const char FakeBluetoothDeviceClient::kPairedDeviceName[] = "Fake Device";
+const char FakeBluetoothDeviceClient::kPairedDeviceName[] =
+ "Fake Device (name)";
+const char FakeBluetoothDeviceClient::kPairedDeviceAlias[] =
+ "Fake Device (alias)";
const uint32_t FakeBluetoothDeviceClient::kPairedDeviceClass = 0x000104;
const char FakeBluetoothDeviceClient::kLegacyAutopairPath[] = "/fake/hci0/dev1";
@@ -239,7 +242,9 @@ const char FakeBluetoothDeviceClient::kPairedUnconnectableDevicePath[] =
const char FakeBluetoothDeviceClient::kPairedUnconnectableDeviceAddress[] =
"20:7D:74:00:00:04";
const char FakeBluetoothDeviceClient::kPairedUnconnectableDeviceName[] =
- "Paired Unconnectable Device";
+ "Paired Unconnectable Device (name)";
+const char FakeBluetoothDeviceClient::kPairedUnconnectableDeviceAlias[] =
+ "Paired Unconnectable Device (alias)";
const uint32_t FakeBluetoothDeviceClient::kPairedUnconnectableDeviceClass =
0x000104;
@@ -310,8 +315,8 @@ FakeBluetoothDeviceClient::FakeBluetoothDeviceClient()
base::Unretained(this), dbus::ObjectPath(kPairedDevicePath))));
properties->address.ReplaceValue(kPairedDeviceAddress);
properties->bluetooth_class.ReplaceValue(kPairedDeviceClass);
- properties->name.ReplaceValue("Fake Device (Name)");
- properties->alias.ReplaceValue(kPairedDeviceName);
+ properties->name.ReplaceValue(kPairedDeviceName);
+ properties->alias.ReplaceValue(kPairedDeviceAlias);
properties->paired.ReplaceValue(true);
properties->trusted.ReplaceValue(true);
properties->adapter.ReplaceValue(
@@ -333,8 +338,8 @@ FakeBluetoothDeviceClient::FakeBluetoothDeviceClient()
dbus::ObjectPath(kPairedUnconnectableDevicePath))));
properties->address.ReplaceValue(kPairedUnconnectableDeviceAddress);
properties->bluetooth_class.ReplaceValue(kPairedUnconnectableDeviceClass);
- properties->name.ReplaceValue("Fake Device 2 (Unconnectable)");
- properties->alias.ReplaceValue(kPairedUnconnectableDeviceName);
+ properties->name.ReplaceValue(kPairedUnconnectableDeviceName);
+ properties->alias.ReplaceValue(kPairedUnconnectableDeviceAlias);
properties->paired.ReplaceValue(true);
properties->trusted.ReplaceValue(true);
properties->adapter.ReplaceValue(
« no previous file with comments | « device/bluetooth/dbus/fake_bluetooth_device_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698