Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2166933002: [arc-intents] Deal correctly with default ports. (Closed)

Created:
4 years, 5 months ago by Ben Kwa
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[arc-intents] Deal correctly with default ports. Loosen the match requirements for ports so that URLs are matched regardless of whether the port was implicitly (i.e. the default) or explicitly specified. This provides an optimistic filter that ensures the disambiguation code doesn't get skipped in the case of potential matches. BUG=628788 Review-Url: https://codereview.chromium.org/2159203003 Cr-Commit-Position: refs/heads/master@{#406644} (cherry picked from commit d8692456882c5cde70eb246fc11b9372032d3992) Committed: https://chromium.googlesource.com/chromium/src/+/5fef25947fb5aa192eb5542c42231736e08b22c2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M components/arc/intent_helper/intent_filter.cc View 1 chunk +12 lines, -1 line 0 comments Download
M components/arc/intent_helper/intent_filter_unittest.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Ben Kwa
4 years, 5 months ago (2016-07-20 20:02:00 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5fef25947fb5aa192eb5542c42231736e08b22c2.

Powered by Google App Engine
This is Rietveld 408576698