Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2159203003: [arc-intents] Deal correctly with default ports. (Closed)

Created:
4 years, 5 months ago by Ben Kwa
Modified:
4 years, 5 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[arc-intents] Deal correctly with default ports. Loosen the match requirements for ports so that URLs are matched regardless of whether the port was implicitly (i.e. the default) or explicitly specified. This provides an optimistic filter that ensures the disambiguation code doesn't get skipped in the case of potential matches. BUG=628788 Committed: https://crrev.com/d8692456882c5cde70eb246fc11b9372032d3992 Cr-Commit-Position: refs/heads/master@{#406644}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M components/arc/intent_helper/intent_filter.cc View 1 chunk +12 lines, -1 line 0 comments Download
M components/arc/intent_helper/intent_filter_unittest.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Ben Kwa
4 years, 5 months ago (2016-07-19 17:42:20 UTC) #3
Yusuke Sato
lgtm
4 years, 5 months ago (2016-07-20 07:03:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159203003/1
4 years, 5 months ago (2016-07-20 19:05:28 UTC) #6
rickyz (no longer on Chrome)
lgtm
4 years, 5 months ago (2016-07-20 19:12:50 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 19:51:37 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 19:52:58 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8692456882c5cde70eb246fc11b9372032d3992
Cr-Commit-Position: refs/heads/master@{#406644}

Powered by Google App Engine
This is Rietveld 408576698