Issue 2166883002: Pass CPDF_Document instead of CPDF_AnnotList when constructing CPDF_Annot.

Issue 2166883002: Pass CPDF_Document instead of CPDF_AnnotList when constructing CPDF_Annot. (Closed)

Created:
4 years, 5 months ago by jaepark

Modified:
4 years, 5 months ago

Reviewers:
Lei Zhang, dsinclair

CC:
pdfium-reviews_googlegroups.com, dsinclair

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Project:
pdfium

Visibility:
Public.

Pass CPDF_Document instead of CPDF_AnnotList when constructing CPDF_Annot. CPDF_AnnotList in CPDF_Annot is only used for getting CPDF_Document. Committed: https://pdfium.googlesource.com/pdfium/+/cc8ae2fd891f71c5d548a042f4d265463887ee6c

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -7 lines)			Patch
	M	core/fpdfdoc/doc_annot.cpp	View		3 chunks	+4 lines, -4 lines	0 comments	Download
	M	core/fpdfdoc/include/fpdf_doc.h	View		3 chunks	+2 lines, -3 lines	0 comments	Download

Total messages: 12 (8 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166883002/1

4 years, 5 months ago (2016-07-20 18:19:53 UTC) #10

commit-bot: I haz the power

4 years, 5 months ago (2016-07-20 18:20:05 UTC) #12

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/cc8ae2fd891f71c5d548a042f4d265463887...