core/fpdfdoc/include/fpdf_doc.h - Issue 2166883002: Pass CPDF_Document instead of CPDF_AnnotList when constructing CPDF_Annot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfdoc/include/fpdf_doc.h

Issue 2166883002: Pass CPDF_Document instead of CPDF_AnnotList when constructing CPDF_Annot. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/fpdfdoc/include/fpdf_doc.h

diff --git a/core/fpdfdoc/include/fpdf_doc.h b/core/fpdfdoc/include/fpdf_doc.h

index fd5dde09a067a37c657d11760b0d69b78141e2e3..887b0dc5b1767e2341c8a762ea94ff106006916e 100644

--- a/core/fpdfdoc/include/fpdf_doc.h

+++ b/core/fpdfdoc/include/fpdf_doc.h

@@ -320,7 +320,7 @@ class CPDF_Annot {

public:

enum AppearanceMode { Normal, Rollover, Down };

- CPDF_Annot(CPDF_Dictionary* pDict, CPDF_AnnotList* pList);

+ CPDF_Annot(CPDF_Dictionary* pDict, CPDF_Document* pDocument);

~CPDF_Annot();

CFX_ByteString GetSubType() const;

@@ -345,7 +345,7 @@ class CPDF_Annot {

private:

CPDF_Dictionary* const m_pAnnotDict;

- CPDF_AnnotList* const m_pList;

+ CPDF_Document* const m_pDocument;

const CFX_ByteString m_sSubtype;

std::map<CPDF_Stream*, CPDF_Form*> m_APMap;

};

@@ -378,7 +378,6 @@ class CPDF_AnnotList {

const std::vector<std::unique_ptr<CPDF_Annot>>& All() const {

return m_AnnotList;

}

- CPDF_Document* GetDocument() const { return m_pDocument; }

protected:

void DisplayPass(CPDF_Page* pPage,

« no previous file with comments | « core/fpdfdoc/doc_annot.cpp ('k') | no next file » | no next file with comments »