Remove layoutObject() dependency from HTMLPlugInElement::layoutObjectIsFocusable().

Remove layoutObject() dependency from HTMLPlugInElement::layoutObjectIsFocusable().

- Introduce HTMLPlugInElement::m_pluginIsAvailable.
  It is equivalent to:
    layoutObject() && layoutObject()->isEmbeddedObject() &&
    !layoutEmbeddedItem().showsUnavailablePluginIndicator()

- Remove LayoutEmbeddedObject::m_showsUnavailablePluginIndicator.
  Add PluginAvailable state to PluginUnavailabilityReason, and rename it to
  PluginAvailability.  We can replace m_showsUnavailablePluginIndicator with
  |m_pluginAvailability != PluginAvailable|.

This CL should not have any behavior changes.

BUG=630066
Committed: https://crrev.com/d0e00543bb2990a7478964be5fc613181bbdd249
Cr-Commit-Position: refs/heads/master@{#406786}

[tkent, 2016-07-21 01:20:38]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 01:20:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-07-21 01:20:59]

Description was changed from

==========
Remove layoutObject() dependency from
HTMLPlugInElement::layoutObjectIsFocusable().

- Introduce HTMLPlugInElement::m_pluginIsAvailable.
  It is equivalent to:
    layoutObject() && layoutObject()->isEmbeddedObject() &&
    !layoutEmbeddedItem().showsUnavailablePluginIndicator()

- Remove LayoutEmbeddedObject::m_showsUnavailablePluginIndicator.
  Add PluginAvailable state to m_pluginUnavailabilityReason, and we can replace
  m_showsUnavailablePluginIndicator with |m_pluginUnavailabilityReason !=
  PluginAvailable|.

This CL should not have any behaivor changes.

BUG=630066
==========

to

==========
Remove layoutObject() dependency from
HTMLPlugInElement::layoutObjectIsFocusable().

- Introduce HTMLPlugInElement::m_pluginIsAvailable.
  It is equivalent to:
    layoutObject() && layoutObject()->isEmbeddedObject() &&
    !layoutEmbeddedItem().showsUnavailablePluginIndicator()

- Remove LayoutEmbeddedObject::m_showsUnavailablePluginIndicator.
  Add PluginAvailable state to m_pluginUnavailabilityReason, and we can replace
  m_showsUnavailablePluginIndicator with |m_pluginUnavailabilityReason !=
  PluginAvailable|.

This CL should not have any behavior changes.

BUG=630066
==========

[commit-bot: I haz the power, 2016-07-21 01:32:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 01:32:29]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[tkent, 2016-07-21 01:50:35]

tkent@chromium.org changed reviewers:
+ kochi@chromium.org

[tkent, 2016-07-21 01:50:36]

kochi@, would you review this please?

[kochi, 2016-07-21 02:09:56]

https://codereview.chromium.org/2166813005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp (right):

https://codereview.chromium.org/2166813005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp:76: }
It seems compilers are complaining that on cases not caught in switch-case,
nothing is returned.

https://codereview.chromium.org/2166813005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.h (right):

https://codereview.chromium.org/2166813005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.h:39: // TODO(tkent):
Rename this to PluginAvailability.
Why not now?
Is this making this change too large?

It is okay to split the patch smaller, though, but we don't have good reason to
keep this TODO for a long time.

[tkent, 2016-07-21 02:21:07]

https://codereview.chromium.org/2166813005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp (right):

https://codereview.chromium.org/2166813005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp:76: }
On 2016/07/21 at 02:09:56, kochi wrote:
> It seems compilers are complaining that on cases not caught in switch-case,
> nothing is returned.

Try bots are red because of other reasons, I think.

https://codereview.chromium.org/2166813005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.h (right):

https://codereview.chromium.org/2166813005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.h:39: // TODO(tkent):
Rename this to PluginAvailability.
On 2016/07/21 at 02:09:56, kochi wrote:
> Why not now?
> Is this making this change too large?
> 
> It is okay to split the patch smaller, though, but we don't have good reason
to
> keep this TODO for a long time.

ok, will do.

[kochi, 2016-07-21 02:27:21]

https://codereview.chromium.org/2166813005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp (right):

https://codereview.chromium.org/2166813005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp:76: }
On 2016/07/21 02:21:07, tkent wrote:
> On 2016/07/21 at 02:09:56, kochi wrote:
> > It seems compilers are complaining that on cases not caught in switch-case,
> > nothing is returned.
> 
> Try bots are red because of other reasons, I think.

See this, for this case.
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel...

[tkent, 2016-07-21 04:06:11]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 04:06:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-07-21 04:07:47]

Description was changed from

==========
Remove layoutObject() dependency from
HTMLPlugInElement::layoutObjectIsFocusable().

- Introduce HTMLPlugInElement::m_pluginIsAvailable.
  It is equivalent to:
    layoutObject() && layoutObject()->isEmbeddedObject() &&
    !layoutEmbeddedItem().showsUnavailablePluginIndicator()

- Remove LayoutEmbeddedObject::m_showsUnavailablePluginIndicator.
  Add PluginAvailable state to m_pluginUnavailabilityReason, and we can replace
  m_showsUnavailablePluginIndicator with |m_pluginUnavailabilityReason !=
  PluginAvailable|.

This CL should not have any behavior changes.

BUG=630066
==========

to

==========
Remove layoutObject() dependency from
HTMLPlugInElement::layoutObjectIsFocusable().

- Introduce HTMLPlugInElement::m_pluginIsAvailable.
  It is equivalent to:
    layoutObject() && layoutObject()->isEmbeddedObject() &&
    !layoutEmbeddedItem().showsUnavailablePluginIndicator()

- Remove LayoutEmbeddedObject::m_showsUnavailablePluginIndicator.
  Add PluginAvailable state to PluginUnavailabilityReason, and rename it to
  PluginAvailability.  We can replace m_showsUnavailablePluginIndicator with
  |m_pluginAvailability != PluginAvailable|.

This CL should not have any behavior changes.

BUG=630066
==========

[tkent, 2016-07-21 04:08:26]

Uploaded a new CL.  Please take another look at it.

https://codereview.chromium.org/2166813005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp (right):

https://codereview.chromium.org/2166813005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp:76: }
On 2016/07/21 at 02:27:21, kochi wrote:
> On 2016/07/21 02:21:07, tkent wrote:
> > On 2016/07/21 at 02:09:56, kochi wrote:
> > > It seems compilers are complaining that on cases not caught in
switch-case,
> > > nothing is returned.
> > 
> > Try bots are red because of other reasons, I think.
> 
> See this, for this case.
>
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel...

Oh, you're right.  Thank you.

[commit-bot: I haz the power, 2016-07-21 04:09:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 04:09:54]

Dry run: Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kochi, 2016-07-21 05:03:29]

lgtm

[kochi, 2016-07-21 05:04:23]

https://codereview.chromium.org/2166813005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLPlugInElement.h (right):

https://codereview.chromium.org/2166813005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLPlugInElement.h:145: // avoid to access
|layoutObject()| in layoutObjectIsFocusable().
nit: avoid accessing

[tkent, 2016-07-21 05:07:22]

https://codereview.chromium.org/2166813005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLPlugInElement.h (right):

https://codereview.chromium.org/2166813005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLPlugInElement.h:145: // avoid to access
|layoutObject()| in layoutObjectIsFocusable().
On 2016/07/21 at 05:04:23, kochi wrote:
> nit: avoid accessing

Done.

[tkent, 2016-07-21 05:07:24]

The CQ bit was checked by tkent@chromium.org

[tkent, 2016-07-21 05:07:25]

The patchset sent to the CQ was uploaded after l-g-t-m from kochi@chromium.org
Link to the patchset: https://codereview.chromium.org/2166813005/#ps40001
(title: "comment grammar")

[commit-bot: I haz the power, 2016-07-21 05:07:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 06:26:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-21 06:30:02]

Description was changed from

==========
Remove layoutObject() dependency from
HTMLPlugInElement::layoutObjectIsFocusable().

- Introduce HTMLPlugInElement::m_pluginIsAvailable.
  It is equivalent to:
    layoutObject() && layoutObject()->isEmbeddedObject() &&
    !layoutEmbeddedItem().showsUnavailablePluginIndicator()

- Remove LayoutEmbeddedObject::m_showsUnavailablePluginIndicator.
  Add PluginAvailable state to PluginUnavailabilityReason, and rename it to
  PluginAvailability.  We can replace m_showsUnavailablePluginIndicator with
  |m_pluginAvailability != PluginAvailable|.

This CL should not have any behavior changes.

BUG=630066
==========

to

==========
Remove layoutObject() dependency from
HTMLPlugInElement::layoutObjectIsFocusable().

- Introduce HTMLPlugInElement::m_pluginIsAvailable.
  It is equivalent to:
    layoutObject() && layoutObject()->isEmbeddedObject() &&
    !layoutEmbeddedItem().showsUnavailablePluginIndicator()

- Remove LayoutEmbeddedObject::m_showsUnavailablePluginIndicator.
  Add PluginAvailable state to PluginUnavailabilityReason, and rename it to
  PluginAvailability.  We can replace m_showsUnavailablePluginIndicator with
  |m_pluginAvailability != PluginAvailable|.

This CL should not have any behavior changes.

BUG=630066

Committed: https://crrev.com/d0e00543bb2990a7478964be5fc613181bbdd249
Cr-Commit-Position: refs/heads/master@{#406786}
==========

[commit-bot: I haz the power, 2016-07-21 06:30:03]

Patchset 3 (id:??) landed as
https://crrev.com/d0e00543bb2990a7478964be5fc613181bbdd249
Cr-Commit-Position: refs/heads/master@{#406786}