third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.h - Issue 2166813005: Remove layoutObject() dependency from HTMLPlugInElement::layoutObjectIsFocusable().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.h

Issue 2166813005: Remove layoutObject() dependency from HTMLPlugInElement::layoutObjectIsFocusable(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comment grammar Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.h b/third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.h

index fc45dbb5914da3f3b4c28d4b89a04babe9a6b745..0d7fc485dc7c9c93e574608b4f1b934d990501ca 100644

--- a/third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.h

+++ b/third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.h

@@ -36,11 +36,12 @@ public:

LayoutEmbeddedObject(Element*);

~LayoutEmbeddedObject() override;

- enum PluginUnavailabilityReason {

+ enum PluginAvailability {

+ PluginAvailable,

PluginMissing,

PluginBlockedByContentSecurityPolicy,

};

- void setPluginUnavailabilityReason(PluginUnavailabilityReason);

+ void setPluginAvailability(PluginAvailability);

bool showsUnavailablePluginIndicator() const;

const char* name() const override { return "LayoutEmbeddedObject"; }

@@ -64,8 +65,7 @@ private:

CompositingReasons additionalCompositingReasons() const override;

- bool m_showsUnavailablePluginIndicator;

- PluginUnavailabilityReason m_pluginUnavailabilityReason;

+ PluginAvailability m_pluginAvailability = PluginAvailable;

String m_unavailablePluginReplacementText;

};