|
|
Chromium Code Reviews
DescriptionRunning 3 ProgGuard optimization passes.
This increases release build time by 30s, reduces our .dex size by 33k,
and saves us 2k memory per process.
BUG=620371
Committed: https://crrev.com/fc1a80d5d329dd4a1cce9886cadf85100f1edcb4
Cr-Commit-Position: refs/heads/master@{#408464}
Patch Set 1 #Patch Set 2 : Running 3 ProgGuard optimization passes #
Total comments: 1
Patch Set 3 : updated comment to say "dirty memory per process" #Patch Set 4 : rebased #Messages
Total messages: 26 (17 generated)
The CQ bit was checked by smaier@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
smaier@chromium.org changed reviewers: + agrieve@chromium.org, yfriedman@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/07/20 14:35:01, smaier wrote: lgtm
On 2016/07/20 15:31:56, agrieve wrote: > On 2016/07/20 14:35:01, smaier wrote: > > lgtm lgtm. I would add high order metrics changes (-memory/size +build time) in case someone's trying to bisect :)
https://codereview.chromium.org/2166813002/diff/20001/base/android/base_progu... File base/android/base_proguard_config.flags (right): https://codereview.chromium.org/2166813002/diff/20001/base/android/base_progu... base/android/base_proguard_config.flags:54: # passes. child process dirty memory, right? not browser. worth specifying
Description was changed from ========== Running 3 ProgGuard optimization passes BUG=620371 ========== to ========== Running 3 ProgGuard optimization passes. This increases release build time by 30s, reduces our .dex size by 33k, and saves us 2k memory per process. BUG=620371 ==========
The CQ bit was checked by smaier@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by smaier@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yfriedman@chromium.org, agrieve@chromium.org Link to the patchset: https://codereview.chromium.org/2166813002/#ps40001 (title: "updated comment to say "dirty memory per process"")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by smaier@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yfriedman@chromium.org, agrieve@chromium.org Link to the patchset: https://codereview.chromium.org/2166813002/#ps60001 (title: "rebased")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Running 3 ProgGuard optimization passes. This increases release build time by 30s, reduces our .dex size by 33k, and saves us 2k memory per process. BUG=620371 ========== to ========== Running 3 ProgGuard optimization passes. This increases release build time by 30s, reduces our .dex size by 33k, and saves us 2k memory per process. BUG=620371 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Running 3 ProgGuard optimization passes. This increases release build time by 30s, reduces our .dex size by 33k, and saves us 2k memory per process. BUG=620371 ========== to ========== Running 3 ProgGuard optimization passes. This increases release build time by 30s, reduces our .dex size by 33k, and saves us 2k memory per process. BUG=620371 Committed: https://crrev.com/fc1a80d5d329dd4a1cce9886cadf85100f1edcb4 Cr-Commit-Position: refs/heads/master@{#408464} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/fc1a80d5d329dd4a1cce9886cadf85100f1edcb4 Cr-Commit-Position: refs/heads/master@{#408464} |
