Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 2166813002: Running 3 ProgGuard optimization passes (Closed)

Created:
4 years, 5 months ago by smaier
Modified:
4 years, 4 months ago
Reviewers:
Yaron, agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Running 3 ProgGuard optimization passes. This increases release build time by 30s, reduces our .dex size by 33k, and saves us 2k memory per process. BUG=620371 Committed: https://crrev.com/fc1a80d5d329dd4a1cce9886cadf85100f1edcb4 Cr-Commit-Position: refs/heads/master@{#408464}

Patch Set 1 #

Patch Set 2 : Running 3 ProgGuard optimization passes #

Total comments: 1

Patch Set 3 : updated comment to say "dirty memory per process" #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M base/android/base_proguard_config.flags View 1 2 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (17 generated)
smaier
4 years, 5 months ago (2016-07-20 14:35:01 UTC) #4
agrieve
On 2016/07/20 14:35:01, smaier wrote: lgtm
4 years, 5 months ago (2016-07-20 15:31:56 UTC) #7
Yaron
On 2016/07/20 15:31:56, agrieve wrote: > On 2016/07/20 14:35:01, smaier wrote: > > lgtm lgtm. ...
4 years, 5 months ago (2016-07-20 16:20:03 UTC) #8
Yaron
https://codereview.chromium.org/2166813002/diff/20001/base/android/base_proguard_config.flags File base/android/base_proguard_config.flags (right): https://codereview.chromium.org/2166813002/diff/20001/base/android/base_proguard_config.flags#newcode54 base/android/base_proguard_config.flags:54: # passes. child process dirty memory, right? not browser. ...
4 years, 5 months ago (2016-07-20 17:10:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166813002/40001
4 years, 4 months ago (2016-07-28 15:31:03 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/103697) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, ...
4 years, 4 months ago (2016-07-28 15:35:11 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166813002/60001
4 years, 4 months ago (2016-07-28 19:39:20 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-07-28 20:28:28 UTC) #24
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 20:30:34 UTC) #26
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/fc1a80d5d329dd4a1cce9886cadf85100f1edcb4
Cr-Commit-Position: refs/heads/master@{#408464}

Powered by Google App Engine
This is Rietveld 408576698