Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: base/android/base_proguard_config.flags

Issue 2166813002: Running 3 ProgGuard optimization passes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/android/base_proguard_config.flags
diff --git a/base/android/base_proguard_config.flags b/base/android/base_proguard_config.flags
index 904ee9842320f64e2f0affc48228f36a040dbfdd..2926ee1238a130681cfc6a4e1956406eb84b42e8 100644
--- a/base/android/base_proguard_config.flags
+++ b/base/android/base_proguard_config.flags
@@ -50,6 +50,17 @@
static *** isLoggable(...);
}
+# The following chart was created on July 20, 2016, to decide on 3 optimization
+# passes.
+# optimization passes | time | .dex size | dirty memory per process
+# -----------------------------------------------------------------
+# 1 | 0:48 | 5805676 | 488972
+# 2 | 1:07 | 5777376 | 487092
+# 3 | 1:24 | 5772192 | 486596
+# 4 | 1:42 | 5771124 | 486484
+# 5 | 1:56 | 5770504 | 486432
+-optimizationpasses 3
+
# Class merging provides negligible .dex size reduction and method count
# reduction (about 0.3% improvement on method count, and 0.1% savings on size),
# and it messes up stack traces if the classes are optimized. Thus, it is in our
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698