Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1273)

Issue 2166683002: MSE: Remove check for not 'updating' in {set,clear}LiveSeekableRange() (Closed)

Created:
4 years, 5 months ago by wolenetz
Modified:
4 years, 5 months ago
Reviewers:
chcunningham
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

MSE: Remove check for not 'updating' in {set,clear}LiveSeekableRange() Anticipating a spec change to remove this 'updating' check to fix spec issue https://github.com/w3c/media-source/issues/118, these methods no longer throw exception if any of the SourceBuffers in sourceBuffers are currently updating. [1] https://github.com/w3c/web-platform-tests/pull/3296 BUG=627880, 624037 TBR=chcunningham@chromium.org TEST=Expected update [1, above] to upstream wpt/media-source/mediasource-liveseekable.html fails before and passes after this change (with --enable-experimental-web-platform-features in both cases, of course). Review-Url: https://codereview.chromium.org/2144063002 Cr-Commit-Position: refs/heads/master@{#405309} (cherry picked from commit dbebef53441200e0ce94dcd41668df78c93f568e) Committed: https://chromium.googlesource.com/chromium/src/+/9b7e73684803bcf4adb6b47af752d1b81ad200e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M third_party/WebKit/Source/modules/mediasource/MediaSource.cpp View 3 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
wolenetz
4 years, 5 months ago (2016-07-20 00:10:43 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9b7e73684803bcf4adb6b47af752d1b81ad200e2.

Powered by Google App Engine
This is Rietveld 408576698