MSE: Remove check for not 'updating' in {set,clear}LiveSeekableRange()

MSE: Remove check for not 'updating' in {set,clear}LiveSeekableRange()

Anticipating a spec change to remove this 'updating' check to fix
spec issue https://github.com/w3c/media-source/issues/118, these methods
no longer throw exception if any of the SourceBuffers in sourceBuffers
are currently updating.

[1] https://github.com/w3c/web-platform-tests/pull/3296

BUG=627880, 624037
R=chcunningham@chromium.org
TEST=Expected update [1, above] to upstream
wpt/media-source/mediasource-liveseekable.html fails before and passes
after this change (with --enable-experimental-web-platform-features in
both cases, of course).

Committed: https://crrev.com/dbebef53441200e0ce94dcd41668df78c93f568e
Cr-Commit-Position: refs/heads/master@{#405309}

[wolenetz, 2016-07-13 18:33:50]

chcunningham@, please take a look. IMHO, Chromium should take this ASAP even if
MSE spec v1 doesn't include it. This change gives greater utility to the
{set,clear}LiveSeekableRange() feature. See the comments in the related
https://bugs.chromium.org/p/chromium/issues/detail?id=627880,
https://github.com/w3c/media-source/issues/118, and
https://github.com/w3c/media-source/pull/119.

vadimgo@, servolk@: FYI

[chcunningham, 2016-07-13 19:24:06]

LGTM % nit

https://codereview.chromium.org/2144063002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/mediasource/MediaSource.cpp (right):

https://codereview.chromium.org/2144063002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/mediasource/MediaSource.cpp:533: //    Note:
With anticipated change to remove this 'updating' check to fix
Nit: this is hard to read. If you make a separate throwExceptionIfClosed, then
you don't need to give this explanation about the faked false.

[wolenetz, 2016-07-13 19:51:54]

Thanks for the review, Chris.

https://codereview.chromium.org/2144063002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/mediasource/MediaSource.cpp (right):

https://codereview.chromium.org/2144063002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/mediasource/MediaSource.cpp:533: //    Note:
With anticipated change to remove this 'updating' check to fix
On 2016/07/13 19:24:06, chcunningham wrote:
> Nit: this is hard to read. If you make a separate throwExceptionIfClosed, then
> you don't need to give this explanation about the faked false. 

Done.

[wolenetz, 2016-07-13 19:52:00]

The CQ bit was checked by wolenetz@chromium.org

[wolenetz, 2016-07-13 19:52:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
chcunningham@chromium.org
Link to the patchset: https://codereview.chromium.org/2144063002/#ps20001
(title: "Fix nit")

[commit-bot: I haz the power, 2016-07-13 19:53:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 22:37:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-13 22:37:58]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 22:39:17]

Description was changed from

==========
MSE: Remove check for not 'updating' in {set,clear}LiveSeekableRange()

Anticipating a spec change to remove this 'updating' check to fix
spec issue https://github.com/w3c/media-source/issues/118, these methods
no longer throw exception if any of the SourceBuffers in sourceBuffers
are currently updating.

[1] https://github.com/w3c/web-platform-tests/pull/3296

BUG=627880,624037
R=chcunningham@chromium.org
TEST=Expected update [1, above] to upstream
wpt/media-source/mediasource-liveseekable.html fails before and passes
after this change (with --enable-experimental-web-platform-features in
both cases, of course).
==========

to

==========
MSE: Remove check for not 'updating' in {set,clear}LiveSeekableRange()

Anticipating a spec change to remove this 'updating' check to fix
spec issue https://github.com/w3c/media-source/issues/118, these methods
no longer throw exception if any of the SourceBuffers in sourceBuffers
are currently updating.

[1] https://github.com/w3c/web-platform-tests/pull/3296

BUG=627880,624037
R=chcunningham@chromium.org
TEST=Expected update [1, above] to upstream
wpt/media-source/mediasource-liveseekable.html fails before and passes
after this change (with --enable-experimental-web-platform-features in
both cases, of course).

Committed: https://crrev.com/dbebef53441200e0ce94dcd41668df78c93f568e
Cr-Commit-Position: refs/heads/master@{#405309}
==========

[commit-bot: I haz the power, 2016-07-13 22:39:19]

Patchset 2 (id:??) landed as
https://crrev.com/dbebef53441200e0ce94dcd41668df78c93f568e
Cr-Commit-Position: refs/heads/master@{#405309}