Pass buildbucket.build.id to cbuildbot as --buildbucket-id.

Pass buildbucket.build.id to cbuildbot as --buildbucket-id.

BUG=chromium:629688
Committed: https://chromium.googlesource.com/chromium/tools/build/+/b3e62f30e334a0eb3c8dfb1a85744f7bdaedcc44

[nxia1, 2016-07-20 00:09:24]

nxia@google.com changed reviewers:
+ dnj@chromium.org

[nxia1, 2016-07-20 00:09:24]

nxia@google.com changed required reviewers:
+ dnj@chromium.org

[dnj (Google), 2016-07-20 01:37:05]

dnj@google.com changed reviewers:
+ dnj@google.com

[dnj (Google), 2016-07-20 01:37:06]

Looks pretty good, comments.

https://codereview.chromium.org/2166673002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromite/api.py (right):

https://codereview.chromium.org/2166673002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromite/api.py:6: import json
We actually have a recipe module called "json":
https://github.com/luci/recipes-py/blob/master/recipe_modules/json/api.py#L76

You can import it by adding "json" to DEPS in "__init__.py".

https://codereview.chromium.org/2166673002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromite/api.py:75: buildbucket_json =
json.loads(self.m.properties.get('buildbucket'))
Use recipe module "self.m.json.loads" here instead of "loads".

https://codereview.chromium.org/2166673002/diff/1/scripts/slave/recipes/cros/...
File scripts/slave/recipes/cros/cbuildbot_tryjob.py (right):

https://codereview.chromium.org/2166673002/diff/1/scripts/slave/recipes/cros/...
scripts/slave/recipes/cros/cbuildbot_tryjob.py:6: import json
(Same w/ JSON recipe module)

https://codereview.chromium.org/2166673002/diff/1/scripts/slave/recipes/cros/...
scripts/slave/recipes/cros/cbuildbot_tryjob.py:194:
buildbucket=json.dumps({'build': {'id':'12345'}})
(api.json.dumps....)

[nxia1, 2016-07-20 05:24:22]

https://codereview.chromium.org/2166673002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromite/api.py (right):

https://codereview.chromium.org/2166673002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromite/api.py:6: import json
On 2016/07/20 01:37:06, dnj (Google) wrote:
> We actually have a recipe module called "json":
> https://github.com/luci/recipes-py/blob/master/recipe_modules/json/api.py#L76
> 
> You can import it by adding "json" to DEPS in "__init__.py".

looks like it's already imported.

https://codereview.chromium.org/2166673002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromite/api.py:75: buildbucket_json =
json.loads(self.m.properties.get('buildbucket'))
On 2016/07/20 01:37:06, dnj (Google) wrote:
> Use recipe module "self.m.json.loads" here instead of "loads".

Done.

https://codereview.chromium.org/2166673002/diff/1/scripts/slave/recipes/cros/...
File scripts/slave/recipes/cros/cbuildbot_tryjob.py (right):

https://codereview.chromium.org/2166673002/diff/1/scripts/slave/recipes/cros/...
scripts/slave/recipes/cros/cbuildbot_tryjob.py:194:
buildbucket=json.dumps({'build': {'id':'12345'}})
On 2016/07/20 01:37:06, dnj (Google) wrote:
> (api.json.dumps....)

api.json in GenTests uses
https://github.com/luci/recipes-py/blob/master/recipe_modules/json/test_api.py
which doesn't provide the dumps method. 

should add a dumps() method in json/test_api.py first?

[dnj (Google), 2016-07-20 06:00:40]

lgtm

https://codereview.chromium.org/2166673002/diff/1/scripts/slave/recipes/cros/...
File scripts/slave/recipes/cros/cbuildbot_tryjob.py (right):

https://codereview.chromium.org/2166673002/diff/1/scripts/slave/recipes/cros/...
scripts/slave/recipes/cros/cbuildbot_tryjob.py:194:
buildbucket=json.dumps({'build': {'id':'12345'}})
On 2016/07/20 05:24:22, nxia1 wrote:
> On 2016/07/20 01:37:06, dnj (Google) wrote:
> > (api.json.dumps....)
> 
> api.json in GenTests uses
> https://github.com/luci/recipes-py/blob/master/recipe_modules/json/test_api.py
> which doesn't provide the dumps method. 
> 
> should add a dumps() method in json/test_api.py first?

Ugh well that's dumb. Looks like other recipes have also had to import "json"
for test, so let's just go with that.

[nxia1, 2016-07-20 17:22:08]

The CQ bit was checked by nxia@google.com

[nxia1, 2016-07-20 17:22:13]

The CQ bit was unchecked by nxia@google.com

[nxia1, 2016-07-20 17:24:29]

The CQ bit was checked by nxia@google.com

[commit-bot: I haz the power, 2016-07-20 17:24:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 17:24:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 17:24:39]

All required reviewers (with asterisk prefixes) have not yet approved this CL.

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-infra-committers".
Note that this has nothing to do with OWNERS files.

[dnj, 2016-07-20 17:25:37]

The CQ bit was checked by dnj@chromium.org

[dnj, 2016-07-20 17:25:40]

lgtm

[commit-bot: I haz the power, 2016-07-20 17:25:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 17:30:44]

Description was changed from

==========
Pass buildbucket.build.id to cbuildbot as --buildbucket-id.

BUG=chromium:629688
==========

to

==========
Pass buildbucket.build.id to cbuildbot as --buildbucket-id.

BUG=chromium:629688

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/b3e62f30e334a0eb3c8d...
==========

[commit-bot: I haz the power, 2016-07-20 17:30:45]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/b3e62f30e334a0eb3c8d...