scripts/slave/recipes/cros/cbuildbot_tryjob.py - Issue 2166673002: Pass buildbucket.build.id to cbuildbot as --buildbucket-id.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/cros/cbuildbot_tryjob.py

Issue 2166673002: Pass buildbucket.build.id to cbuildbot as --buildbucket-id. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: use_json_recipe Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/chromite/config.py ('k') | scripts/slave/recipes/cros/cbuildbot_tryjob.expected/pre_cq_buildbucket_config.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/cros/cbuildbot_tryjob.py

diff --git a/scripts/slave/recipes/cros/cbuildbot_tryjob.py b/scripts/slave/recipes/cros/cbuildbot_tryjob.py

index 5c3e8ab3d79f06ff309e8dd60081bceb9c559e12..0127fe98be408d2121a6bdd74b6b2dd854300bf9 100644

--- a/scripts/slave/recipes/cros/cbuildbot_tryjob.py

+++ b/scripts/slave/recipes/cros/cbuildbot_tryjob.py

@@ -3,6 +3,7 @@

# found in the LICENSE file.

import base64

+import json

import zlib

@@ -177,3 +178,20 @@ def GenTests(api):

)

+ api.chromite.seed_chromite_config(_CHROMITE_CONFIG)

)

+ # Test a config with buildbucket properties

+ yield (

+ api.test('pre_cq_buildbucket_config')

+ + api.properties(

+ mastername='chromiumos.tryserver',

+ buildername='pre-cq',

+ slavename='test',

+ repository='https://chromium.googlesource.com/chromiumos/tryjobs.git',

+ revision=api.gitiles.make_hash('test'),

+ cbb_config='binhost-pre-cq',

+ cbb_extra_args='["--timeout", "14400", "--remote-trybot",'

+ '"--remote-version=4"]',

+ buildbucket=json.dumps({'build': {'id':'12345'}})

+ )

+ + api.chromite.seed_chromite_config(_CHROMITE_CONFIG)

+ )