extensions/DEPS - Issue 2166523003: Add ref count to service workers for extension API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/DEPS

Issue 2166523003: Add ref count to service workers for extension API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments from Devlin + MichaelN Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_version.cc ('K') | « content/renderer/service_worker/service_worker_context_client.cc ('k') | extensions/browser/bad_message.h » ('j') | extensions/browser/extension_function.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/DEPS

diff --git a/extensions/DEPS b/extensions/DEPS

index 0765359a65a83989d568f790fd500788192bc8ae..b5910aa3158b97c58c76831048fc8c087088113c 100644

--- a/extensions/DEPS

+++ b/extensions/DEPS

@@ -7,6 +7,7 @@ include_rules = [

"+components/url_matcher",

"+components/version_info",

"-content",

+ "+content/common",

Devlin 2016/10/06 16:35:12 This won't be allowed.

Devlin 2016/10/06 16:36:13 Whoops, meant to circle back to this. Will we be

lazyboy 2016/10/06 17:57:37 Ah, I keep confusing content/common for content/pu

"+content/grit/content_resources.h",

"+content/public/common",

"+content/public/test",