extensions/DEPS - Issue 2166523003: Add ref count to service workers for extension API.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/DEPS

Issue 2166523003: Add ref count to service workers for extension API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments from Devlin + MichaelN Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/service_worker/service_worker_version.cc ('K') | « content/renderer/service_worker/service_worker_context_client.cc ('k') | extensions/browser/bad_message.h » ('j') | extensions/browser/extension_function.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 # Do not add Chrome dependencies. Much work went into removing them.	2 # Do not add Chrome dependencies. Much work went into removing them.

3 "+components/browsing_data",	3 "+components/browsing_data",

4 "+components/crx_file",	4 "+components/crx_file",

5 "+components/guest_view",	5 "+components/guest_view",

6 "+components/prefs",	6 "+components/prefs",

7 "+components/url_matcher",	7 "+components/url_matcher",

8 "+components/version_info",	8 "+components/version_info",

9 "-content",	9 "-content",

	10 "+content/common",
	Devlin 2016/10/06 16:35:12 This won't be allowed. This won't be allowed. Devlin 2016/10/06 16:36:13 Whoops, meant to circle back to this. Will we be Show quoted text On 2016/10/06 16:35:12, Devlin wrote: > This won't be allowed. Whoops, meant to circle back to this. Will we be able to pull content::kInvalidServiceWorkerVersionId into content/public/common to avoid this? lazyboy 2016/10/06 17:57:37 Ah, I keep confusing content/common for content/pu Show quoted text On 2016/10/06 16:36:13, Devlin wrote: > On 2016/10/06 16:35:12, Devlin wrote: > > This won't be allowed. > > Whoops, meant to circle back to this. Will we be able to pull > content::kInvalidServiceWorkerVersionId into content/public/common to avoid > this? Ah, I keep confusing content/common for content/public/common. I prefer do the change separately, for now I've copied the constant to extensions/common/constants.h
10 "+content/grit/content_resources.h",	11 "+content/grit/content_resources.h",

11 "+content/public/common",	12 "+content/public/common",

12 "+content/public/test",	13 "+content/public/test",

13 "+crypto",	14 "+crypto",

14 "-extensions/components",	15 "-extensions/components",

15 "+extensions/test",	16 "+extensions/test",

16 "+grit/extensions_renderer_resources.h",	17 "+grit/extensions_renderer_resources.h",

17 "+grit/extensions_resources.h",	18 "+grit/extensions_resources.h",

18 "+mojo/public",	19 "+mojo/public",

19 "+testing",	20 "+testing",

(...skipping 31 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
51 "+chrome/browser/extensions/test_extension_prefs.h",	52 "+chrome/browser/extensions/test_extension_prefs.h",

52 "+chrome/browser/extensions/test_extension_system.h",	53 "+chrome/browser/extensions/test_extension_system.h",

53 "+chrome/browser/ui/browser.h",	54 "+chrome/browser/ui/browser.h",

54 "+chrome/common/chrome_switches.h",	55 "+chrome/common/chrome_switches.h",

55 "+chrome/common/extensions/features/feature_channel.h",	56 "+chrome/common/extensions/features/feature_channel.h",

56 "+chrome/test/base/chrome_render_view_test.h",	57 "+chrome/test/base/chrome_render_view_test.h",

57 "+chrome/test/base/testing_profile.h",	58 "+chrome/test/base/testing_profile.h",

58 "+chrome/test/base/ui_test_utils.h",	59 "+chrome/test/base/ui_test_utils.h",

59 ],	60 ],

60 }	61 }

OLD	NEW