Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: extensions/browser/bad_message.cc

Issue 2166523003: Add ref count to service workers for extension API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments from falken@ Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/bad_message.cc
diff --git a/extensions/browser/bad_message.cc b/extensions/browser/bad_message.cc
index a0dacaac13b2672f84e2b05928589947bb851615..12d6f54113976647331b9b93e6d5463fc848e19e 100644
--- a/extensions/browser/bad_message.cc
+++ b/extensions/browser/bad_message.cc
@@ -6,19 +6,34 @@
#include "base/logging.h"
#include "base/metrics/sparse_histogram.h"
+#include "content/public/browser/browser_message_filter.h"
#include "content/public/browser/render_process_host.h"
namespace extensions {
namespace bad_message {
-void ReceivedBadMessage(content::RenderProcessHost* host,
- BadMessageReason reason) {
+namespace {
+
+void LogBadMessage(BadMessageReason reason) {
LOG(ERROR) << "Terminating extension renderer for bad IPC message, reason "
<< reason;
UMA_HISTOGRAM_SPARSE_SLOWLY("Stability.BadMessageTerminated.Extensions",
reason);
+}
+
+} // namespace
+
+void ReceivedBadMessage(content::RenderProcessHost* host,
+ BadMessageReason reason) {
+ LogBadMessage(reason);
host->ShutdownForBadMessage();
}
+void ReceivedBadMessage(content::BrowserMessageFilter* filter,
+ BadMessageReason reason) {
+ LogBadMessage(reason);
+ filter->ShutdownForBadMessage();
+}
+
} // namespace bad_message
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698