Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2045)

Unified Diff: extensions/browser/bad_message.h

Issue 2166523003: Add ref count to service workers for extension API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments from falken@ Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/bad_message.h
diff --git a/extensions/browser/bad_message.h b/extensions/browser/bad_message.h
index bef0c712b388f95f45cf4666a2301b08b1dde0fc..7ed44c9b3221f89e589f32fa0ab75e9d02a71466 100644
--- a/extensions/browser/bad_message.h
+++ b/extensions/browser/bad_message.h
@@ -6,6 +6,7 @@
#define EXTENSIONS_BROWSER_BAD_MESSAGE_H_
namespace content {
+class BrowserMessageFilter;
class RenderProcessHost;
}
@@ -28,6 +29,10 @@ enum BadMessageReason {
AVG_BAD_INST_ID = 4,
AVG_BAD_EXT_ID = 5,
AVG_NULL_AVG = 6,
+ // Invalid increment of an Extensions SW ref count.
+ ESWMF_INVALID_INCREMENT_ACTIVIY = 7,
+ // Invalid decrement of an Extensions SW ref count.
+ ESWMF_INVALID_DECREMENT_ACTIVIY = 8,
// Please add new elements here. The naming convention is abbreviated class
// name (e.g. ExtensionHost becomes EH) plus a unique description of the
// reason. After making changes, you MUST update histograms.xml by running:
@@ -41,6 +46,12 @@ enum BadMessageReason {
void ReceivedBadMessage(content::RenderProcessHost* host,
BadMessageReason reason);
+// Called when a browser message filter receives a bad IPC message from a
+// renderer or other child process. Logs the event, records a histogram metric
+// for the |reason|, and terminates the process for |filter|.
+void ReceivedBadMessage(content::BrowserMessageFilter* filter,
+ BadMessageReason reason);
+
} // namespace bad_message
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698