Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4760)

Unified Diff: chrome/browser/extensions/api/tabs/tabs_api.cc

Issue 2166523003: Add ref count to service workers for extension API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/tabs/tabs_api.cc
diff --git a/chrome/browser/extensions/api/tabs/tabs_api.cc b/chrome/browser/extensions/api/tabs/tabs_api.cc
index 082822b843de360c5af776ec9653ec3abb9dad99..54fe8099122d90a06365263df862945ef1d4d44c 100644
--- a/chrome/browser/extensions/api/tabs/tabs_api.cc
+++ b/chrome/browser/extensions/api/tabs/tabs_api.cc
@@ -1400,9 +1400,19 @@ bool TabsUpdateFunction::UpdateURL(const std::string &url_string,
if (!url.SchemeIs(url::kJavaScriptScheme))
DCHECK_EQ(url.spec(), web_contents_->GetURL().spec());
+ // Add a fake delay add async behavior (and delay) to chrome.tabs.update().
+ *is_async = true;
+ base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
+ FROM_HERE, base::Bind(&TabsUpdateFunction::AfterFakeAsyncDelay, this),
+ base::TimeDelta::FromSeconds(7));
return true;
}
+void TabsUpdateFunction::AfterFakeAsyncDelay() {
+ LOG(ERROR) << "chrome.tabs.update: AfterFakeAsyncDelay fired";
+ SendResponse(true);
+}
+
void TabsUpdateFunction::PopulateResult() {
if (!has_callback())
return;

Powered by Google App Engine
This is Rietveld 408576698