content/browser/service_worker/embedded_worker_instance.h - Issue 2166523003: Add ref count to service workers for extension API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/embedded_worker_instance.h

Issue 2166523003: Add ref count to service workers for extension API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/service_worker/tabs_create/sw.js ('k') | content/browser/service_worker/embedded_worker_instance.cc » ('j') | content/browser/service_worker/service_worker_version.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/embedded_worker_instance.h

diff --git a/content/browser/service_worker/embedded_worker_instance.h b/content/browser/service_worker/embedded_worker_instance.h

index b0b0da93138da1193815bbf7a95011b279b4c46f..f9cfaee996a3f1930b3053de28524afd5265f402 100644

--- a/content/browser/service_worker/embedded_worker_instance.h

+++ b/content/browser/service_worker/embedded_worker_instance.h

@@ -196,6 +196,9 @@ class CONTENT_EXPORT EmbeddedWorkerInstance {

void Detach();

+ void IncrementRefCount();

+ void DecrementRefCount();

falken 2016/07/22 05:06:01 ref count is kind of generic, maybe "IncrementPend

lazyboy 2016/07/26 17:45:48 Done.

base::WeakPtr<EmbeddedWorkerInstance> AsWeakPtr();

private:

@@ -324,6 +327,8 @@ class CONTENT_EXPORT EmbeddedWorkerInstance {

// Used for UMA. The start time of the current start sequence step.

base::TimeTicks step_time_;

+ int external_ref_count_;

base::WeakPtrFactory<EmbeddedWorkerInstance> weak_factory_;

DISALLOW_COPY_AND_ASSIGN(EmbeddedWorkerInstance);