Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2166433003: Implement a more stable way to check if the dialog is fully loaded before choose the sink, instead … (Closed)

Created:
4 years, 5 months ago by Lei Lei
Modified:
4 years, 5 months ago
Reviewers:
imcheng, apacible
CC:
chromium-reviews, media-router+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the flakiness issue in Telemetry tests. + Implement a more stable way to check if the dialog is fully loaded before choose the sink, instead of hardcoding the waiting time. + Also increase the timeout for stopping session. Committed: https://crrev.com/ebfc7be61c8e9a0b3010c101b220d45aecea06be Cr-Commit-Position: refs/heads/master@{#406756}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M chrome/test/media_router/telemetry/benchmarks/pagesets/media_router_page.py View 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/test/media_router/telemetry/benchmarks/pagesets/media_router_perf_pages.py View 3 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Lei Lei
PTAL.
4 years, 5 months ago (2016-07-20 01:07:14 UTC) #2
imcheng
lgtm
4 years, 5 months ago (2016-07-20 01:23:30 UTC) #3
apacible
lgtm wrt description: Update with a crbug id or remove the BUG= line. The first ...
4 years, 5 months ago (2016-07-20 02:11:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166433003/1
4 years, 5 months ago (2016-07-21 03:21:21 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 03:26:08 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 03:28:50 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ebfc7be61c8e9a0b3010c101b220d45aecea06be
Cr-Commit-Position: refs/heads/master@{#406756}

Powered by Google App Engine
This is Rietveld 408576698