Implement a more stable way to check if the dialog is fully loaded before choose the sink, instead …

chrome/test/media_router/telemetry/benchmarks/pagesets/media_router_perf_pages.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import utils
 
 from telemetry import page
 from telemetry import story
 from benchmarks.pagesets import media_router_page
 from telemetry.core import exceptions
@@ skipping 74 matching lines @@
           timeout=30)
       self.CloseExistingRoute(action_runner, sink_name)
 
       # Start session
       action_runner.TapElement(selector='#start_session_button')
       self._WaitForResult(
           action_runner,
           lambda: len(action_runner.tab.browser.tabs) >= 2,
           'MR dialog never showed up.')
 
-      # Wait for 2s to make sure the dialog is fully loaded.
-      action_runner.Wait(2)
       for tab in action_runner.tab.browser.tabs:
         # Choose sink
         if tab.url == 'chrome://media-router/':
+          self.WaitUntilDialogLoaded(action_runner, tab)
           self.ChooseSink(tab, sink_name)
 
       self._WaitForResult(
         action_runner,
         lambda: action_runner.EvaluateJavaScript('currentSession'),
          'Failed to start session',
          timeout=10)
 
       # Load Media
       self.ExecuteAsyncJavaScript(
           action_runner,
           'loadMedia("%s");' % utils.GetInternalVideoURL(),
           lambda: action_runner.EvaluateJavaScript('currentMedia'),
           'Failed to load media',
           timeout=120)
 
       action_runner.Wait(5)
       action_runner.ExecuteJavaScript('collectPerfData();')
       action_runner.Wait(SESSION_TIME)
       # Stop session
       self.ExecuteAsyncJavaScript(
           action_runner,
           'stopSession();',
           lambda: not action_runner.EvaluateJavaScript('currentSession'),
-          'Failed to stop session')
+          'Failed to stop session',
+          timeout=30)
 
 
 class CastMirroringPage(media_router_page.CastPage):
   """Cast page to mirror a tab to Chromecast device."""
 
   def __init__(self, page_set):
     super(CastMirroringPage, self).__init__(
         page_set=page_set,
         url='file://mirroring.html',
         shared_page_state_class=SharedState)
 
   def RunPageInteractions(self, action_runner):
     sink_name = self._GetDeviceName()
     # Wait for 5s after Chrome is opened in order to get consistent results.
     action_runner.Wait(5)
     with action_runner.CreateInteraction('mirroring'):
       self.CloseExistingRoute(action_runner, sink_name)
 
       # Start session
       action_runner.TapElement(selector='#start_session_button')
       self._WaitForResult(
           action_runner,
           lambda: len(action_runner.tab.browser.tabs) >= 2,
           'MR dialog never showed up.')
 
-      # Wait for 2s to make sure the dialog is fully loaded.
-      action_runner.Wait(2)
       for tab in action_runner.tab.browser.tabs:
         # Choose sink
         if tab.url == 'chrome://media-router/':
+          self.WaitUntilDialogLoaded(action_runner, tab)
           self.ChooseSink(tab, sink_name)
 
       # Wait for 5s to make sure the route is created.
       action_runner.Wait(5)
       action_runner.TapElement(selector='#start_session_button')
       action_runner.Wait(2)
       for tab in action_runner.tab.browser.tabs:
         if tab.url == 'chrome://media-router/':
           if not self.CheckIfExistingRoute(tab, sink_name):
             raise page.page_test.Failure('Failed to start mirroring session.')
@@ skipping 22 matching lines @@
     self.AddStory(CastMirroringPage(self))
 
 
 class CPUMemoryPageSet(story.StorySet):
   """Pageset to get baseline CPU and memory usage."""
 
   def __init__(self):
     super(CPUMemoryPageSet, self).__init__(
         cloud_storage_bucket=story.PARTNER_BUCKET)
     self.AddStory(CastIdlePage(self))