Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2166433002: Cleanup CXFA_Document (Closed)

Created:
4 years, 5 months ago by dsinclair
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Cleanup CXFA_Document Removing unused XFA_LAYOUTRESULT, cleanup unused parameters, convert XFA_DocFlag to an enum from defines and make the constructor explicit. Committed: https://pdfium.googlesource.com/pdfium/+/eea31b75a11215aa72a9845d47c38d2ce1edd4f7

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -55 lines) Patch
M xfa/fxfa/app/xfa_ffnotify.cpp View 1 chunk +5 lines, -6 lines 1 comment Download
M xfa/fxfa/parser/xfa_document.h View 3 chunks +38 lines, -35 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_datamerger_imp.cpp View 6 chunks +10 lines, -7 lines 0 comments Download
M xfa/fxfa/parser/xfa_layout_pagemgr_new.cpp View 6 chunks +7 lines, -6 lines 0 comments Download
M xfa/fxfa/parser/xfa_object_imp.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
dsinclair
PTAL. https://codereview.chromium.org/2166433002/diff/1/xfa/fxfa/app/xfa_ffnotify.cpp File xfa/fxfa/app/xfa_ffnotify.cpp (left): https://codereview.chromium.org/2166433002/diff/1/xfa/fxfa/app/xfa_ffnotify.cpp#oldcode189 xfa/fxfa/app/xfa_ffnotify.cpp:189: return (XFA_LAYOUTRESULT)pAcc->FindSplitPos(iBlockIndex, fCalcHeightPos); I have no idea why ...
4 years, 5 months ago (2016-07-19 15:20:13 UTC) #2
Lei Zhang
lgtm
4 years, 5 months ago (2016-07-19 17:24:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166433002/1
4 years, 5 months ago (2016-07-19 17:26:58 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 17:27:16 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/eea31b75a11215aa72a9845d47c38d2ce1ed...

Powered by Google App Engine
This is Rietveld 408576698