xfa/fxfa/parser/xfa_object_imp.cpp - Issue 2166433002: Cleanup CXFA_Document

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/parser/xfa_object_imp.cpp

Issue 2166433002: Cleanup CXFA_Document (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxfa/parser/xfa_object_imp.cpp

diff --git a/xfa/fxfa/parser/xfa_object_imp.cpp b/xfa/fxfa/parser/xfa_object_imp.cpp

index de2f804a4cf67d5f24ab92433862acf0a3f8db38..463247e6406f3a0eda7dcd2ee8c4235df49ed58e 100644

--- a/xfa/fxfa/parser/xfa_object_imp.cpp

+++ b/xfa/fxfa/parser/xfa_object_imp.cpp

@@ -2979,7 +2979,7 @@ static CXFA_Node* XFA_ScriptInstanceManager_CreateInstance(

ASSERT(pDataScope);

}

CXFA_Node* pInstance = pDocument->DataMerge_CopyContainer(

- pTemplateNode, pFormParent, pDataScope, TRUE, bDataMerge);

+ pTemplateNode, pFormParent, pDataScope, TRUE, bDataMerge, TRUE);

if (pInstance) {

pDocument->DataMerge_UpdateBindingRelations(pInstance);

pFormParent->RemoveChild(pInstance);